1922646 - Add a delay between the default Set to Default prompt and showing the INFOBAR_DEFAULT_AND_PIN_87 message

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Meg Viar [:mviar]]

The INFOBAR_DEFAULT_AND_PIN_87 message's targeting may be perceived as not respecting the browser.shell.checkDefaultBrowser pref (this can be set using a checkbox in about:settings). Its targeting includes !isDefaultBrowser && !'browser.shell.checkDefaultBrowser'|preferenceValue.

David Rubino raised this issue on Slack.

Comment 1

[Punam Dahiya [:pdahiya]]

INFOBAR_DEFAULT_AND_PIN_87 showing on targeting !isDefaultBrowser && !'browser.shell.checkDefaultBrowser'|preferenceValue is working as expected. see discussion in implementing https://bugzilla.mozilla.org/show_bug.cgi?id=1703874#c0

This infobar shows as an edgecase only for users who dismissed the set default modal prompt by clicking on checkbox (setting pref browser.shell.checkDefaultBrowser to false) and are profile age between 5 and 15 weeks.

Comment 2

[Meg Viar [:mviar]]

Product suggestion from Alex Davis on Slack - allow the infobar message, waiting some amount a time after the last time they saw the original set to default pop-up.

Comment 3

[Hanna Alemu [:hanna_a]]

Attachment: Bug 1922646 - Add a delay between the default Set to Default prompt and showing the INFOBAR_DEFAULT_AND_PIN_87 message

Comment 4

[Hanna Alemu [:hanna_a]]

NI @Vtay How long should we delay showing the infobar after user last checked 'don't show me set default prompt message again' ? Would 24 hours be enough?

Comment 5

[Punam Dahiya [:pdahiya]]

NI @hanna to clarify if this fix is an uplift candidate Thanks!

Comment 6

[Hanna Alemu [:hanna_a]]

Hi @punam, The infobar is shown to a limited amount of users due to it's targeting conditions, and this bug is not a defect but more of a enhancement so I don't think it needs to be uplifted. I'll update it to 138.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d69b8ab9451d
Add a delay between the default Set to Default prompt and showing the INFOBAR_DEFAULT_AND_PIN_87 message r=omc-reviewers,pdahiya

Comment 8

[amarc]

https://hg.mozilla.org/mozilla-central/rev/d69b8ab9451d

Comment 9

[Shane Hughes [:aminomancer]]

There's a message on remote settings with the same id and it still has the old configuration. Is it overriding this? It comes first in the array, which should mean it's returned first by triggers, which should mean the changes here have no effect.

Try it in console: ChromeUtils.importESModule("resource:///modules/asrouter/ASRouter.sys.mjs").ASRouter.state.messages.filter(m => m.id === "INFOBAR_DEFAULT_AND_PIN_87")

I think we ought to remove the remote settings message. Clearly having it tucked away in a location that is now so obscure is creating pitfalls for us to step in.