1923049 - Extend mach gifft to support boolean scalars

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task)

Description

[Florian Quèze [:florian]]

Bug 1896732 introduced mach gifft to generate glean event definitions from legacy telemetry events. Let's extend this command to support legacy telemetry boolean scalars (other kinds of scalars to follow later).

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1923049 - Extend mach gifft to support scalars, r=chutten.

Depends on D224733

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c3679284df1
Extend mach gifft to support scalars, r=chutten.

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1c3679284df1

Comment 4

[Acasandrei Beatrice (needinfo me)]

(In reply to Pulsebot from comment #2)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c3679284df1
Extend mach gifft to support scalars, r=chutten.

Perfherder has detected a browsertime performance change from push 1c3679284df16242bdee116453e25a61b24a37d4.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
2%	speedometer Inferno-TodoMVC/DeletingItems	windows11-64-shippable-qr	fission webrender	35.15 -> 34.43	Before/After
2%	speedometer Inferno-TodoMVC	windows11-64-shippable-qr	fission webrender	58.23 -> 57.06	Before/After
2%	speedometer Inferno-TodoMVC/DeletingItems/Sync	windows11-64-shippable-qr	fission webrender	34.69 -> 33.99	Before/After

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 2589

For more information on performance sheriffing please see our FAQ.

Comment 5

[Chris H-C :chutten]

It is impossible for this change to have affected runtime perf. This patch made changes to a mach command that is only manually invoked.