1923716 - [Menu redesign] 'Open in Regular Tabs' is missing from the new menu design

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, defect, P3)

Description

[Jonathan Almeida [:jonalmeida]]

This current nightly-only feature is missing from the new menu which can be found in the code around this reference point: https://searchfox.org/mozilla-central/rev/7a85a111b5f42cdc07f438e36f9597c4c6dc1d48/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt#170-177

From comment 9:

If we are taking the implementation directly from the old menu, please remember to remove this check https://github.com/mozilla-mobile/firefox-android/pull/4063/files#diff-4eeee07b301bb58da44424ae0d00eaaa38f61f0f697332841eb3deaa99da0ac3R181

It should show up for all private tabs.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:royang, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Roger Yang [:royang]]

I have notified the design team and they are thinking through this. Thanks

Comment 3

[Paul [pwd]]

(In reply to Roger Yang [:royang] from comment #2)

I have notified the design team and they are thinking through this. Thanks

This was reported 3 months ago in bug 1909044, does that mean nothing was done as a result of that bug being filed?

Comment 4

[Roger Yang [:royang]]

(In reply to Paul [pwd] from comment #3)

This was reported 3 months ago in bug 1909044, does that mean nothing was done as a result of that bug being filed?

Correct, since this feature is only in Nightly and never moved forward into release it was not a priority when designing the new menu system.

Comment 5

[Roger Yang [:royang]]

Decision made regarding this feature from Content Design:

For now, we will continue to keep this a Nightly-only feature with telemetry in place. On the new menu, it will be labeled Move to non-private tab (pending l10n review; this is not final)

• UX proposes keeping this feature in Nightly, private tabs only until the following conditions are met:
• Evaluation of telemetry in Nightly to measure usage relative to other page tools/menu items to gauge demand
• An A/B test (or equivalent measurement) is ran in release AFTER the initial menu experiments are done to gauge impact of this feature
• Exploration of the feasibility of adding a reciprocal menu item to move non-private tabs to private tabs so we don’t have a menu item that is only for private browsing.
• Exploration of feasibility of adding this feature to iOS to avoid having features on one platform only.

The conditions outlined above relate to the goals of this menu project to:

• Be more intentional about the features we add to the menu, basing them on data and user demand
• Avoid (whenever possible) having menu items that only show up under certain conditions, as we know this makes it harder for users to find them.
• Avoid (whenever possible) having features that are designed for one platform only to achieve better parity between iOS and Android

Comment 7

[Roger Yang [:royang]]

When implementing, please make sure to check the l10n review to find the string that we should use https://mozilla-hub.atlassian.net/browse/LR-151

Comment 8

[Roger Yang [:royang]]

Approved string is Move to non-private tab

Comment 9

[Roger Yang [:royang]]

If we are taking the implementation directly from the old menu, please remember to remove this check https://github.com/mozilla-mobile/firefox-android/pull/4063/files#diff-4eeee07b301bb58da44424ae0d00eaaa38f61f0f697332841eb3deaa99da0ac3R181

It should show up for all private tabs.

Comment 10

[Iorga Gabriel]

Attachment: Bug 1923716 - Add open in regular tab in tools menu.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1c5e8a930b3
Add open in regular tab in tools menu. r=android-reviewers,sanchaai

Comment 12

[amarc]

https://hg.mozilla.org/mozilla-central/rev/c1c5e8a930b3