1923844 - Hide sidebar animation reveals desktop during the animation

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect, P2)

Description

[Stuart Colville [:muffinresearch]]

STR:

• Using Ubuntu 24:04 (this seems fine on Mac, we'll need to check if this occurs on windows)
• With sidebar.revamp and the sidebar settings set to "Show and hide sidebar"
• Hide the sidebar with the sidebar button

What happens:

• Hiding the sidebar with the sidebar button reveals the desktop during the animation (see screencast to follow)

What should happen:

• The desktop shouldn't be visible during the hide animation.

Comment 1

[Stuart Colville [:muffinresearch]]

Attachment: Screencast showing desktop visible during close animation

Comment 2

[Stuart Colville [:muffinresearch]]

FWIW: Testing this on Windows 11 I wasn't able to reproduce it there.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1908989

:kcochrane, since you are the author of the regressor, bug 1908989, could you take a look?

For more information, please visit BugBot documentation.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1923844 - Account for hidden elements during sidebar animation in 'Always Hide' mode

This works great except when the sidebar box is shown. That case could
be refined.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c7e306db988
Account for hidden elements during sidebar animation in 'Always Hide' mode r=sidebar-reviewers,sfoster

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/9c7e306db988

Comment 7

[Kelly Cochrane [:kcochrane]]

:ctuns, would you mind also verifying that this update resolved bug 1923936 when you have the chance?

Comment 8

[Cristian Tuns]

Aryx can you please check this out?

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

(In reply to Kelly Cochrane [:kcochrane] from comment #7)

would you mind also verifying that this update resolved bug 1923936 when you have the chance?

Comment 11

[Vanessa Sabino]

Yes, confirmed that it resolved bug 1923936 for me.

Comment 12

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

I was able to reproduce the issue on an affected Firefox Nightly build from 2024-10-10, using Ubuntu 22.04, while following the steps described in Comment 0.
Verified as fixed using Firefox 133.0b9 on Ubuntu 22.04. Desktop is no longer revealed during the hide animation.