1910628 - [Toolbar redesign] Missing navigation bar in custom tab

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, defect, P2)

Description

[Paul [pwd]]

Attachment: Screenshot_20240730-155223.png

User Agent: Mozilla/5.0 (Android 14; Mobile; rv:130.0) Gecko/130.0 Firefox/130.0

Steps to reproduce:

Press a link to open a webpage in a chrome tab (Sync for Lemmy for example)

Actual results:

See a white bar instead of second toolbar

Expected results:

The option to open a tab in normal Firefox

Comment 1

[Roger Yang [:royang]]

No issue should be blocking Nightly anymore. (already shipped in Nightly) Moving to a Beta blocker

Comment 2

[Chris Peterson [:cpeterson]]

P2 because we don't need this bug in our current sprint.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Fenix::Toolbar' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 4

[Delia Pop (Android QA)]

Attachment: PrivateCustomTab.mp4

Can confirm this issue is present in the latest Nightly 139.0a1 from 07/31 with Google Pixel 8 Pro (Android 14), however it was also reproducible when 1909896 and 1908954 were reported. Although the issue was fixed for normal browsing mode, it persists for Private custom tabs.

Additional details to reproduce this issue:

1. In Fenix, go to Settings > Private browsing and enable the "Open links in private tab" option.
2. Set Fenix as default browser.
3. Open an external app (i.e. Gmail, Instagram, Slack) and tap on a link.
4. Observe the Navigation bar in the custom tab.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1902798

:mavduevskiy, since you are the author of the regressor, bug 1902798, could you take a look?

For more information, please visit BugBot documentation.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1902798

Comment 7

[Roger Yang [:royang]]

Can't reproduce this. :Delia, is this still reproducible on nightly. Thanks

Comment 8

[Delia Pop (Android QA)]

Attachment: Nightly_132.mp4

This is still reproducible on my end on the latest Nightly 132.0a1 from 09/06 with Google Pixel 8 Pro (Android 14) and OPPO A15s (Android 10).

Comment 9

[Delia Pop (Android QA)]

Attachment: CustomTabs_NavigationArrows_Themes.jpg

Additionally, using a different theme in Fenix compared to the system theme, affects the contrast between the navigation arrow buttons and the nav bar background.

Comment 10

[Roger Yang [:royang]]

Probably theming related. Check if custom tab is following the private theme.

Comment 11

[[:skhan]]

Hey Aarjav! Should the navbar here follow the dark/light theme or the private theme? I mean do we expect navbar to be purple here or not?

Comment 12

[Aarjav [:aarjav]]

• The custom tab toolbar (address bar + nav bar) always follows the same theme as the Firefox App theme.
• If the links are set to open in private mode in custom tab, the entire toolbar (address bar + nav bar) should follow the private theme.

Comment 13

[[:skhan]]

Attachment: Bug 1910628 - Update navbar color for custom tab

Comment 14

[[:skhan]]

Attachment: screen-20240923-232851.mp4

I've also found an issue while rotating the device. Attaching a video

Context of the issue: The first time the lastKnownMode is calculated using intent extra in HomeActivity which gives the correct value of isPrivate in FirefoxTheme.
However this value gets updated in BaseBrowserFragment and the value here comes from BrowserStore which returns a false value for isPrivate and hence lastKnownMode gets updated to Normal Mode and in turn light or dark theme.

This is a deeper issue which I intend to talk to squad 4 about and see if this is an actual bug or if it is expected.
Until then I will create a part 2 of the patch to work around this.

Comment 15

[[:skhan]]

Attachment: observeNavBarTheme.mp4

Steps to Reproduce the above issue in the codebase.

1. Set Firefox as your default browser.
2. Open Settings -> Private Browsing -> Enable open links in a private tab
   Monitor lastKnownMode value in Settings.kt of when clicking an external link.
   At first it returns the correct value of isPrivate which is true and then it is updated to false as explained in above comment.

Comment 16

[[:skhan]]

Attachment: Bug 1910628 - Fix theme issue of navbar on rotation in custom tab

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e6b3a4d27fc
Update navbar color for custom tab r=android-reviewers,petru

Comment 18

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/8e6b3a4d27fc

Comment 19

[Phabricator Automation]

Comment on attachment 9426683 [details]
Bug 1910628 - Fix theme issue of navbar on rotation in custom tab

Revision D223253 was moved to bug 1925679. Setting attachment 9426683 [details] to obsolete.