Closed Bug 1577541 Opened 3 months ago Closed 2 months ago

Enable megabar pref by default in Nightly

Categories

(Firefox :: Address Bar, task, P1)

task
Points:
3

Tracking

()

VERIFIED FIXED
Firefox 71
Iteration:
71.3 - Sept 30 - Oct 13
Tracking Status
firefox71 --- verified

People

(Reporter: harry, Assigned: dao, NeedInfo)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Megabar should be on by default in 71.

Priority: -- → P1

Note by doing this mochitests may fail if something is broken, so I suggest first checking on Try. It may not be as trivial as a 1 pointer.

Iteration: 71.1 - Sept 2 - 15 → ---
Depends on: 1580538
Points: 1 → 2
Points: 2 → 3
Depends on: 1580792
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Iteration: --- → 71.2 - Sept 16 - 29
Depends on: 1583495

locally in Win10, these tests seem to fail when enabling mb:
toolkit/components/extensions/test/browser/browser_ext_themes_autocomplete_popup.js
browser/base/content/test/performance/browser_windowopen.js
browser/base/content/test/performance/browser_windowclose.js

(In reply to Marco Bonardo [::mak] from comment #4)

browser/base/content/test/performance/browser_windowopen.js
browser/base/content/test/performance/browser_windowclose.js

I think we may have to whitelist the rect for the extended urlbar. We need layout information to extend the urlbar and we can't get that before the first paint without flushing layout... which we don't want either. In my testing (mostly on Linux) the flicker isn't actually visible, so I'm not sure this even matters. What do you think?

Flags: needinfo?(mak77)

Adding a so large area to the whitelist seems a bit excessive considered what the test is trying to do, it would whitelist a large part of the toolbars.
Can we somehow avoid the expansion in specific cases, or for specific windows? That would still "whitelist" the expansion without adding more whitelistes space to the test.

Flags: needinfo?(mak77)

ther emay also be an intermittent at
browser/components/customizableui/test/browser_985815_propagate_setToolbarVisibility.js
TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_985815_propagate_setToolbarVisibility.js | A promise chain failed to handle a rejection: this.window is undefined - stack: _updateLayoutBreakoutDimensions/<@resource:///modules/UrlbarInput.jsm:998:7

And
TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_speculative_connect.js | A promise chain failed to handle a rejection: this.window is undefined - stack: _updateLayoutBreakoutDimensions/<@resource:///modules/UrlbarInput.jsm:998:7

Is this with my WIP patch applied?

No, I was using central and flipping the pref, I'm mostly comparing megabar against megabar + retained results to see if any additional tests would fail. Mostly pointing out failures to have a second look at on Try, you may have fixed some of these already.

Iteration: 71.2 - Sept 16 - 29 → 71.3 - Sept 30 - Oct 13
Summary: Enable megabar pref by default → Enable megabar pref by default in Nightly
Attachment #9094183 - Attachment description: Bug 1577541 - WIP → Bug 1577541 - Enable megabar pref by default in Nightly.
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c9c63f844702
Enable megabar pref by default in Nightly. r=mak
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Regressions: 1586032
Regressions: 1585991
Regressions: 1586197
No longer regressions: 1585912
No longer regressions: 1585958
No longer regressions: 1586032
No longer regressions: 1585991
No longer regressions: 1586197

Dao, could you provide a release note wording for our Nightly notes please? Thanks

Flags: needinfo?(dao+bmo)

(In reply to Pascal Chevrel:pascalc from comment #13)

Dao, could you provide a release note wording for our Nightly notes please? Thanks

Redirecting to verdi.

Flags: needinfo?(dao+bmo) → needinfo?(mverdi)

Updating the flags accordingly.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.