1577541 - Enable megabar pref by default in Nightly

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Harry Twyford]

Megabar should be on by default in 71.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Note by doing this mochitests may fail if something is broken, so I suggest first checking on Try. It may not be as trivial as a 1 pointer.

Comment 2

[Dão Gottwald [:dao]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=999f76d3a7c0035029463dc6af77e56d05adf308

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1577541 - Enable megabar pref by default in Nightly.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

locally in Win10, these tests seem to fail when enabling mb:
toolkit/components/extensions/test/browser/browser_ext_themes_autocomplete_popup.js
browser/base/content/test/performance/browser_windowopen.js
browser/base/content/test/performance/browser_windowclose.js

Comment 5

[Dão Gottwald [:dao]]

(In reply to Marco Bonardo [::mak] from comment #4)

browser/base/content/test/performance/browser_windowopen.js
browser/base/content/test/performance/browser_windowclose.js

I think we may have to whitelist the rect for the extended urlbar. We need layout information to extend the urlbar and we can't get that before the first paint without flushing layout... which we don't want either. In my testing (mostly on Linux) the flicker isn't actually visible, so I'm not sure this even matters. What do you think?

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Adding a so large area to the whitelist seems a bit excessive considered what the test is trying to do, it would whitelist a large part of the toolbars.
Can we somehow avoid the expansion in specific cases, or for specific windows? That would still "whitelist" the expansion without adding more whitelistes space to the test.

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

ther emay also be an intermittent at
browser/components/customizableui/test/browser_985815_propagate_setToolbarVisibility.js
TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_985815_propagate_setToolbarVisibility.js | A promise chain failed to handle a rejection: this.window is undefined - stack: _updateLayoutBreakoutDimensions/<@resource:///modules/UrlbarInput.jsm:998:7

Comment 8

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

And
TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_speculative_connect.js | A promise chain failed to handle a rejection: this.window is undefined - stack: _updateLayoutBreakoutDimensions/<@resource:///modules/UrlbarInput.jsm:998:7

Comment 9

[Dão Gottwald [:dao]]

Is this with my WIP patch applied?

Comment 10

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

No, I was using central and flipping the pref, I'm mostly comparing megabar against megabar + retained results to see if any additional tests would fail. Mostly pointing out failures to have a second look at on Try, you may have fixed some of these already.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9c63f844702
Enable megabar pref by default in Nightly. r=mak

Comment 12

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/c9c63f844702

Comment 13

[Pascal Chevrel:pascalc (PTO until April 26)]

Dao, could you provide a release note wording for our Nightly notes please? Thanks

Comment 14

[Dão Gottwald [:dao]]

(In reply to Pascal Chevrel:pascalc from comment #13)

Dao, could you provide a release note wording for our Nightly notes please? Thanks

Redirecting to verdi.

Comment 15

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

Updating the flags accordingly.