1926360 - Fx View and List all tabs icons don't stay customized switching from vertical to horizontal tabs and back again.

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect, P2)

Description

[Stuart Colville [:muffinresearch]]

STR:

• Start with vertical tabs enabled
• Customize the toolbar and move icons including Fx View and List all Tabs button to the left-hand side.
• Switch to horizontal tabs and note the position of the icons.
• Switch back to vertical tabs and note the position of the icons.

What should happen?

• Icons that were customized should stay in their customized position.

What happens?

• The Fx View Icon, and the List all Tabs icon move back to the right hand side when switching back to vertical tabs. Also the new tab icon (tab with a plus moves too) but that's covered by bug 1923752

Tested on Mac 133.0a1 (2024-10-22) (aarch64)

Comment 1

[Stuart Colville [:muffinresearch]]

Attachment: Screen recording showing customization in vertical tabs, switching to horizontal tabs and back again.

Comment 2

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1926360 - Save customized fxview, list all tabs button and other tab strip widget locations in nav bar when vertical tabs enabled r=#sidebar-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f04379a895c4
Save customized fxview, list all tabs button and other tab strip widget locations in nav bar when vertical tabs enabled r=sidebar-reviewers,sclements,mconley

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_verticalTabs_widget_placements.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/a18968a513fe1b867168fcd687f7b52d34d3e2c2

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/sidebar/tests/browser/browser_verticalTabs_widget_placements.js

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a498f80a4000
Save customized fxview, list all tabs button and other tab strip widget locations in nav bar when vertical tabs enabled r=sidebar-reviewers,sclements,mconley

Comment 6

[Norisz Fay [:noriszfay]]

Backed out for causing bc failures on browser_unified_extensions_vertical_tabs.js

Backout link

Push with failures

Failure log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6d0fbdef190
Save customized fxview, list all tabs button and other tab strip widget locations in nav bar when vertical tabs enabled r=sidebar-reviewers,sclements,mconley

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/d6d0fbdef190

Comment 9

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 133.0a1 (2024-10-22) on Windows 10 x64. The Fx View Icon, and the List all Tabs icon move back after following steps from comment 0.
The issue is verified fixed with Firefox 135.0b5 on Windows 10x64, macOS 12 and Ubuntu 24.04. The Fx View Icon, and the List all Tabs icon no longer moves back after following steps from comment 0.