1935892 - Removed Firefox View button returns after restart

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect, P1)

Description

[gwarser]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:135.0) Gecko/20100101 Firefox/135.0

Steps to reproduce:

• right click on the Firefox View button and select "Remove from Toolbar" or click "Customize Toolbar..." and drag the button out
• restart the browser

Actual results:

The button is back on the Toolbar

Expected results:

It should be hidden

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Firefox View' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c989b7bd05b81c0072bd2621c6b92c3aa9618b4f&tochange=d6d0fbdef190091e5dac0c7fe409befc4c95bd36

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:nsharpley, since you are the author of the regressor, bug 1926360, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox135 (nightly). However, the bug still isn't assigned.

:pluk, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 6

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1935892 - Fix removed Firefox View button return after restart r=#sidebar-reviewers

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e4bd8f9ba97
Fix removed Firefox View button return after restart r=sidebar-reviewers,sfoster

Comment 11

[amarc]

https://hg.mozilla.org/mozilla-central/rev/8e4bd8f9ba97

Comment 12

[Monica Chiorean]

I was able to reproduce it on Win11x64 using FF build 135.0a1(20241209213901).
Verified as fixed on Win11x64/Ubuntu22.04 using FF build 136.0a1 and 135.0b4.