1926489 - [Toolbar redesign] When in a custom tab the Android status bar should match the toolbar colour

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, task, P2)

Description

[Daniel Holbert [:dholbert]]

Steps to reproduce

1. Set Fenix as your default browser
2. Ensure that Fenix is showing its "navigation bar" (separate bar from URLbar, with back/forward buttons and 3-dot-menu). If this isn't enabled for you (which is possible depending on A/B testing), you can turn it on in the Secret Settings menu
3. Set your system-theme to "Light" and your Firefox Theme to "Dark" [EDIT: the firefox theme doesn't actually matter for this bug. Just the system theme is relevant.]
4. Tap a link in the Gmail app (which is using the light system-theme), and look at the UI in the custom tab that appears.

Expected behavior

Light status bar at the top of the screen (to match the light system theme that we're adopting for other toolbars from the light gmail-app/system theme).

Actual behavior

Dark status bar at the top of the screen.

Device information

• Firefox version: 133.0a1 2024-10-22 (not in play store yet, but installed via mozregression). Also reproduced in 2024-10-18 and 2024-10-17 (before/after bug 1925070 landed -- so this is not a regression from that particular bug's patches to change the status bar).
• Android device model: Pixel 8
• Android OS version: 15

Any additional information?

This only reproduces when Fenix's navbar is enabled (per STR step 2). If you turn off Firefox's navigation bar in STR step 2, then Nightly 2024-10-18 and newer give me EXPECTED RESULTS here (whereas Nightly 2024-10-17 gives a rendering similar to bug 1925070 with dark-text-on-dark-background under that configuration with the rest of the STR).

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot of bug (notice black Android status-bar at top of screen)

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screenshot of correct rendering if I turn off Fenix's navigation bar (notice white Android status-bar at top of screen)

Comment 3

[Daniel Holbert [:dholbert]]

(I tested with the urlbar-on-bottom-vs-top and it didn't make a difference to this bug's reproducibility. It's just specifically the presence/absence of the Fenix navbar that seems to trigger this mismatch.)

Comment 4

[Daniel Holbert [:dholbert]]

Actually, the Firefox theme doesn't matter here - I can leave that setting at "follow device theme" and I can still reproduce this bug. --> adjusted the STR and bug title to reflect that. (The system theme itself does still need to be "light" in order to repro this issue, though.)

I was able to bisect this to the following regression range with mozregression:
Newest known good nightly: 2024-07-17
Oldest known bad nightly: 2024-07-18
Pushlog (using the hg revs from those builds' internal "about" pages):
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e2109b806cd9&tochange=888f6e45052a

In that range, this is presumably a regression from bug 1904325.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1904325

:petru, since you are the author of the regressor, bug 1904325, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 6

[Petru-Mugurel Lingurar [:petru]]

This is the desired behaviour and not a regression.
In Aarjav's words "we always use black because we want to the system status bar to "be compatible" with any toolbar color that the third-party app might specify."

Note that we will move to always show the OS navigation bar as black (even for normal/private browsing) in bug 1922419.
Will double check if the status bar colour needs any update in custom tab (changing it from always black)

Comment 7

[Petru-Mugurel Lingurar [:petru]]

After checking with UX we got that when in a custom tab the status bar should have the same colour as the toolbar.
Our Figma designs will be updated.
Will take the liberty to rename/update this ticket.
Thanks for raising this!

Comment 8

[Daniel Holbert [:dholbert]]

Thanks! Relatedly: in dark mode, only when using a custom tab, these bars seem to be black rather than Firetox's gray color. (No such issue in the full app.) See screenshot that a user just posted over on bug 1925587 comment 12. Is that something that might be fixed as part of this bug, or should we file that separately?

Comment 9

[Petru-Mugurel Lingurar [:petru]]

(In reply to Daniel Holbert [:dholbert] from comment #8)

Thanks! Relatedly: in dark mode, only when using a custom tab, these bars seem to be black rather than Firetox's gray color. (No such issue in the full app.) See screenshot that a user just posted over on bug 1925587 comment 12. Is that something that might be fixed as part of this bug, or should we file that separately?

When bug 1904325 was implemented we wanted to have black status bar and black OS navigation bar in custom tabs when navbar is enabled.
This ticket remains to change that to allow the status bar to follow the toolbar colour - same as without the navbar - enabled after more evaluation.
But the navigation bar will remain black when the navbar is enabled in all browsing modes (custom tab / normal browsing / private browsing).
So no need to open a new ticket, that is functioning as intended.

Comment 10

[Daniel Holbert [:dholbert]]

Thanks for the reply. Let me clarify something though:

(In reply to Petru-Mugurel Lingurar [:petru] from comment #9)

the navigation bar will remain black when the navbar is enabled in all browsing modes (custom tab / normal browsing / private browsing).
So no need to open a new ticket, that is functioning as intended.

So, right now in Nightly with navbar enabled, the Android navigation bar is not black in normal browsing or private browsing (though it sounds like you might be saying it is black & would remain so). Right now in the full Firefox Nightly app (with navbar enabled), the Android navigation bar matches the Firefox toolbar color (i.e. it's either white or dark-gray in normal browsing, and purple in private browsing -- never black).

It's only in custom-tabs where the navigation bar and status bar appear to be both hardcoded to black, regardless of Firefox's theme + toolbar-color.

So I don't think this is functioning as-intended, at least not in the way that you were describing, since custom-tabs do seem to be getting different navbar coloring (black) vs. other modes (dark-gray/white/purple)

Comment 11

[Petru-Mugurel Lingurar [:petru]]

(In reply to Daniel Holbert [:dholbert] from comment #10)

So I don't think this is functioning as-intended, at least not in the way that you were describing, since custom-tabs do seem to be getting different navbar coloring (black) vs. other modes (dark-gray/white/purple)

Tried to say in comment 6 that custom tabs have a different behaviour currently - as per bug 1904325: when the navbar is enabled both system bars - the status bar and the OS navigation bar will be black.
While bug 1922419 (for which a patch was just merged) will ensure the OS navigation bar will be black for all browsing modes.

Based on your report we checked with UX and for the scenario of custom tabs with navbar enabled we will allow only the status bar to use the same colour as the toolbar - same behavior as with navbar disabled. And this ticket will support that change.

The specs around this did change over time in an effort to showcase the new navbar and avoid UX conflicts with the system bars.
What I described above are the current specs.

Comment 12

[Daniel Holbert [:dholbert]]

Gotcha, ok - I understand now, thanks for clarifying. (I can also confirm that the navbar is now indeed black in all browsing modes, in mozregression-installed Nightly 2024-10-24, which I think includes bug 1922419).

Anyway: comment 8 up through this comment here was a bit of a tangent; thanks for indulging me on that. Returning to this bug here, about the status-bar color (at the top): this remains reproducible in e.g. latest Nightly 2024-10-24, independent of the navbar-coloring (at the bottom). I think that's known; just posting for clarity, partly for myself when coming back to this later on after the details of the changes here have faded from memory.

Comment 13

[[:harrisono]]

https://bugzilla.mozilla.org/show_bug.cgi?id=1922419#c2

According to this comment, the OS status bar should always be black for all modes and themes that use a bottom navigation bar.

Attaching screenshot showing that Custom Tabs now show a dark OS status bar.

Comment 14

[[:harrisono]]

Attachment: Custom Tab shows dark OS bar as expected.

Comment 15

[Daniel Holbert [:dholbert]]

(In reply to [:harrisono] from comment #13)

https://bugzilla.mozilla.org/show_bug.cgi?id=1922419#c2

According to this comment, the OS status bar should always be black for all modes and themes that use a bottom navigation bar.

That comment was about the system nav-bar (bottom of the screen), not the status bar (top of the screen). Bug 1922419 comment 0 has a bit more detail to clarify that that bug's considerations are not about forcing black on the status bar at the top of the screen.

Comment 16

[Daniel Holbert [:dholbert]]

Having said that: testing Nightly 2024-10-17 [EDIT: typo, I meant to say 2024-10-27], I think I'm seeing expected-results (light status bar at top of screen) -- so this might indeed have been fixed, though not in the way that comment 14 would suggest.

I'm off to an appointment at the moment but I'll circle back to confirm that this is fixed & find a fix-range a bit later today.

Comment 17

[[:harrisono]]

Ah I see my mistake, thank you for clarifying. I'll check the status bar at the top of the screen.

Comment 18

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #16)

Having said that: testing Nightly 2024-10-17 [EDIT: typo, I meant to say 2024-10-27], I think I'm seeing expected-results (light status bar at top of screen)

Never mind, I can still reproduce a dark status-bar at the top -- it's just intermittent. This didn't repro in my existing Firefox session on my Pixel 8 for a little while (I was reliably getting expected-results with a white status-bar at the top), but then after I killed Firefox and then tapped a link in gmail, I got the actual-results again, and I'm reliably getting actual-results no matter what I do now. I also tested on my Pixel 6a, and immediately got actual-results when testing latest Nightly there.

(I'm currently testing using the system "light" theme and with Firefox and Gmail both set to follow system default, BTW. Both of the phones I'm testing are using Android 15.)

Comment 19

[[:harrisono]]

Attachment: Bug 1926489 - Update System Status Bar to appropriate theme in CustomTabs

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/04112249cb1d
Update System Status Bar to appropriate theme in CustomTabs r=android-reviewers,skhan

Comment 21

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/04112249cb1d

Comment 22

[Ryan VanderMeulen [:RyanVM]]

Is this something we should keep on the radar for a possible 133 dot release or is riding 134 sufficient?