1927093 - Migrate scalars to glean - part 2

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task)

Description

[Florian Quèze [:florian]]

Continuation of bug 1923028.

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1927093 - Migrate scalars using scalarSetMaximum to Glean APIs in BrowserUsageTelemetry.sys.mjs, r=chutten.

Comment 2

[Florian Quèze [:florian]]

Attachment: Bug 1927093 - Remove constants used for scalar names in BrowserUsageTelemetry.sys.mjs, r=chutten.

Comment 3

[Florian Quèze [:florian]]

Attachment: Bug 1927093 - Migrate scalars to use Glean APIs for urlbar.picked.*, r=chutten.

Comment 4

[Florian Quèze [:florian]]

Attachment: Bug 1927093 - Migrate scalars to use Glean APIs for urlbar.impression.*, r=chutten.

Comment 5

[Florian Quèze [:florian]]

Attachment: Bug 1927093 - Migrate scalars to use Glean APIs for urlbar.*, r=chutten.

Comment 6

[Florian Quèze [:florian]]

Attachment: Bug 1927093 - Migrate scalars to use Glean APIs for browser.engagement.* (excluding browser.engagement.navigation.*), r=chutten.

Comment 7

[Florian Quèze [:florian]]

Attachment: Bug 1927093 - Migrate scalars to use Glean APIs for browser.searchinit.*, r=chutten.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba395fae680e
Migrate scalars using scalarSetMaximum to Glean APIs in BrowserUsageTelemetry.sys.mjs, r=chutten,sessionstore-reviewers,sfoster.
https://hg.mozilla.org/integration/autoland/rev/f6a823357cb0
Remove constants used for scalar names in BrowserUsageTelemetry.sys.mjs, r=chutten.

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ba395fae680e
https://hg.mozilla.org/mozilla-central/rev/f6a823357cb0

Comment 10

[Florian Quèze [:florian]]

Attachment: Bug 1927093 - Migrate scalars to use Glean APIs for quickaction.*, r=chutten.

Depends on D226371

Comment 11

[Florian Quèze [:florian]]

Attachment: Bug 1927093 - Migrate scalars to use Glean APIs for contextual.services.topsites.*, r=chutten.

Depends on D227814

Comment 12

[Florian Quèze [:florian]]

Attachment: Bug 1927093 - Migrate scalars to use Glean APIs in browser-captivePortal.js, r=chutten.

Depends on D227815

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d9c8bd16879
Migrate scalars to use Glean APIs for urlbar.picked.*, r=chutten,urlbar-reviewers,Standard8.
https://hg.mozilla.org/integration/autoland/rev/25f66109f2c1
Migrate scalars to use Glean APIs for urlbar.impression.*, r=chutten,urlbar-reviewers,Standard8.
https://hg.mozilla.org/integration/autoland/rev/0635c2618813
Migrate scalars to use Glean APIs for urlbar.*, r=chutten,urlbar-reviewers,mak.
https://hg.mozilla.org/integration/autoland/rev/41fc1d1412c3
Migrate scalars to use Glean APIs for browser.engagement.* (excluding browser.engagement.navigation.*), r=chutten,sessionstore-reviewers,tabbrowser-reviewers,places-reviewers,sfoster.

Comment 14

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7d9c8bd16879
https://hg.mozilla.org/mozilla-central/rev/25f66109f2c1
https://hg.mozilla.org/mozilla-central/rev/0635c2618813
https://hg.mozilla.org/mozilla-central/rev/41fc1d1412c3

Comment 15

[Florian Quèze [:florian]]

Attachment: Bug 1927093 - Migrate scalars to use Glean APIs in devtools/client/accessibility, r=chutten.

Comment 16

[Florian Quèze [:florian]]

Attachment: Bug 1927093 - Migrate scalars to use Glean APIs for devtools.responsive.*, r=chutten.

Depends on D228155

Comment 17

[Florian Quèze [:florian]]

Attachment: Bug 1927093 - Migrate scalars to use Glean APIs in devtools/client/framework, r=chutten.

Depends on D228156

Comment 18

[Florian Quèze [:florian]]

Attachment: Bug 1927093 - Migrate scalars to use Glean APIs in devtools/client/shared/telemetry.js, r=chutten.

Depends on D228157

Comment 19

[Florian Quèze [:florian]]

Attachment: Bug 1927093 - Migrate scalars to use Glean APIs in devtools/client/inspector, r=chutten.

Depends on D228158

Comment 20

[Florian Quèze [:florian]]

Attachment: Bug 1927093 - Remove scalar helpers from devtools/client/shared/telemetry.js, r=chutten.

Depends on D228159

Comment 21

[Florian Quèze [:florian]]

Attachment: Bug 1927093 - Migrate scalars to use Glean APIs for mozstorage.sqlitejsm_transaction_timeout, r=chutten.

Comment 22

[Florian Quèze [:florian]]

Attachment: Bug 1927093 - Migrate scalars to use Glean APIs for normandy.recipe_freshness, r=chutten.

Depends on D228298

Comment 23

[Florian Quèze [:florian]]

Attachment: Bug 1927093 - Migrate scalars to use Glean APIs for browser.search.data_transferred, r=chutten.

Depends on D228299

Comment 24

[Florian Quèze [:florian]]

Attachment: Bug 1927093 - Migrate scalars to use Glean APIs for script.preloader.mainthread_recompile, r=chutten.

Depends on D228300

Comment 25

[Florian Quèze [:florian]]

Attachment: Bug 1927093 - Migrate scalars to use Glean APIs for timestamps.*, r=chutten.

Depends on D228301

Comment 26

[Florian Quèze [:florian]]

Attachment: Bug 1927093 - Migrate scalars to use Glean APIs for browser.timings.last_shutdown, r=chutten.

Depends on D228302

Comment 27

[Phabricator Automation]

Comment on attachment 9436107 [details]
Bug 1927093 - Migrate scalars to use Glean APIs for browser.search.data_transferred, r=chutten.

Revision D228300 was moved to bug 1929129. Setting attachment 9436107 [details] to obsolete.

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e264d5631584
Migrate scalars to use Glean APIs in devtools/client/accessibility, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/023dfef4f392
Migrate scalars to use Glean APIs for devtools.responsive.*, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/b2f81696d593
Migrate scalars to use Glean APIs in devtools/client/framework, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/054dbeaaa7f1
Migrate scalars to use Glean APIs in devtools/client/shared/telemetry.js, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/fbd75dc8c198
Migrate scalars to use Glean APIs in devtools/client/inspector, r=chutten,devtools-reviewers,nchevobbe.
https://hg.mozilla.org/integration/autoland/rev/9913c2a5e97d
Remove scalar helpers from devtools/client/shared/telemetry.js, r=chutten,devtools-reviewers,nchevobbe.

Comment 29

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/e264d5631584
https://hg.mozilla.org/mozilla-central/rev/023dfef4f392
https://hg.mozilla.org/mozilla-central/rev/b2f81696d593
https://hg.mozilla.org/mozilla-central/rev/054dbeaaa7f1
https://hg.mozilla.org/mozilla-central/rev/fbd75dc8c198
https://hg.mozilla.org/mozilla-central/rev/9913c2a5e97d

Comment 30

[Florian Quèze [:florian]]

Attachment: Bug 1927093 - Migrate scalars to use Glean APIs for deletion.request.*, r=chutten.

Depends on D228300

Comment 31

[Florian Quèze [:florian]]

Attachment: Bug 1927093 - Migrate scalars to use Glean APIs in browser/extensions/formautofill, r=chutten.

Comment 32

[Florian Quèze [:florian]]

Attachment: Bug 1927093 - Migrate scalars to use Glean APIs for formautofill.addresses.* and formautofill.creditCards.*, r=chutten.

Depends on D228455

Comment 33

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d0a7e8245ed
Migrate scalars to use Glean APIs for quickaction.*, r=chutten,daleharvey.

Comment 34

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/520359a55ea9
Migrate scalars to use Glean APIs in browser-captivePortal.js, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/82514cd87f0d
Migrate scalars to use Glean APIs for mozstorage.sqlitejsm_transaction_timeout, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/d0bafc035229
Migrate scalars to use Glean APIs for script.preloader.mainthread_recompile, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/78d916df5d07
Migrate scalars to use Glean APIs for timestamps.*, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/c8b93e415fb7
Migrate scalars to use Glean APIs for browser.timings.last_shutdown, r=chutten.

Comment 35

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/2d0a7e8245ed
https://hg.mozilla.org/mozilla-central/rev/520359a55ea9
https://hg.mozilla.org/mozilla-central/rev/82514cd87f0d
https://hg.mozilla.org/mozilla-central/rev/d0bafc035229
https://hg.mozilla.org/mozilla-central/rev/78d916df5d07
https://hg.mozilla.org/mozilla-central/rev/c8b93e415fb7

Comment 36

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc2066cf26cc
Migrate scalars to use Glean APIs for contextual.services.topsites.*, r=chutten,urlbar-reviewers,jteow,Standard8,home-newtab-reviewers,thecount.

Comment 37

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac5026a66d85
Migrate scalars to use Glean APIs in browser/extensions/formautofill, r=chutten,credential-management-reviewers,jneuberger,dimi.
https://hg.mozilla.org/integration/autoland/rev/9b5128b9b3d4
Migrate scalars to use Glean APIs for formautofill.addresses.* and formautofill.creditCards.*, r=chutten,credential-management-reviewers,issammani,dimi.

Comment 38

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/142eaa96ddf2
Migrate scalars to use Glean APIs for deletion.request.*, r=chutten,sync-reviewers,home-newtab-reviewers,mconley,markh.

Comment 39

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a77f4e4c93d2
Migrate scalars to use Glean APIs for browser.searchinit.*, r=chutten,search-reviewers,Standard8.
https://hg.mozilla.org/integration/autoland/rev/9f3a65b72655
Migrate scalars to use Glean APIs for normandy.recipe_freshness, r=chutten.

Comment 40

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/bc2066cf26cc
https://hg.mozilla.org/mozilla-central/rev/ac5026a66d85
https://hg.mozilla.org/mozilla-central/rev/9b5128b9b3d4

Comment 41

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/142eaa96ddf2
https://hg.mozilla.org/mozilla-central/rev/a77f4e4c93d2
https://hg.mozilla.org/mozilla-central/rev/9f3a65b72655

Comment 42

[Florian Quèze [:florian]]

Attachment: The script I used to generate patches

For future reference, I'm attaching the node.js script I used to automate some of the work to produce patches that landed in this bug.