1928452 - Enable support for new in-app notifications types: blog, donation_tab & donation_browser

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Toby Pilling [:tobyp]]

In bug 1918832 we added support for 'donations_old'.

We would like to change this into two separate and similar types

donation_browser - opens the URL in browser (so just rename donation_old)
donation_tab - opens the URL in TB tab as can be seen in bug 1925383

In both of these cases, a notification window will not be created or inserted.

We would also like to prioritize the "blog" type which is the 'blue' template in the Figma file with title "Thunderbird User Survey"

Comment 1

[Alex Schmitz]

Attachment: Bug 1928452 - Add blog type for in app notifications. r=freaktechnik

Comment 2

[Alex Schmitz]

Attachment: Bug 1928452 - Change in app notification type donation_old to donation_browser. r=freaktechnik

Comment 3

[Alex Schmitz]

Attachment: Bug 1928452 - Add donation_tab in app notification type. r=freaktechnik

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e3a286c94b23
Add blog type for in app notifications. r=freaktechnik,micahilbery
https://hg.mozilla.org/comm-central/rev/b56cbc76368a
Change in app notification type donation_old to donation_browser. r=freaktechnik

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7291f9c57156
Add donation_tab in app notification type. r=freaktechnik

Comment 6

[Alex Schmitz]

Comment on attachment 9439168 [details]
Bug 1928452 - Add donation_tab in app notification type. r=freaktechnik

[Approval Request Comment]
User impact if declined: tab based notifications will fail to display
Testing completed (on c-c, etc.): Automated testing
Risk to taking this patch (and alternatives if risky): low is an update to new notifications

Comment 7

[Corey Bryant]

Comment on attachment 9439168 [details]
Bug 1928452 - Add donation_tab in app notification type. r=freaktechnik

[Triage Comment]
Approved for beta

Comment 8

[Corey Bryant]

Thunderbird 134.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/109ba73a99a3