1928508 - Don't log the message "update.locale file doesn't exist" on Firefox installations with no updater

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect, P3)

Description

[Ethan Glasby]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:120.0) Gecko/20100101 Firefox/120.0

Steps to reproduce:

Opened Firefox

Actual results:

Firefox still runs, but logs reveal a number of errors, one of which is:
15:28:50.151 update.locale file doesn't exist in either the application or GRE directories 2 UpdateUtils.sys.mjs:143:13
getLocale resource://gre/modules/UpdateUtils.sys.mjs:143

Expected results:

Firefox should have locate the update.locale file, or create one if appropriate

Comment 1

[Ethan Glasby]

Despite what the user agent suggests, the operating system is aarch64+16k Linux

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Application Update' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Eric Chen]

Hi Ethan, thanks for filing this ticket!

Can you tell me how your Firefox is installed? Was it by the RPM Package Manager by any chance? Or did you download it from the Mozilla website?

Comment 4

[Ethan Glasby]

(In reply to Eric Chen from comment #3)

Hi Ethan, thanks for filing this ticket!

Can you tell me how your Firefox is installed? Was it by the RPM Package Manager by any chance? Or did you download it from the Mozilla website?

It was installed through the DNF Package Manager. Firefox was installed with "sudo dnf install firefox", and is referred to as the package "firefox-132.0-2.fc40.aarch64" by DNF.
I will also add that my OS is Fedora Asahi Remix which, while officially supported by Fedora, also has some oddities such as its use of 16k pagefile size.

Comment 5

[Eric Chen]

Thanks for the information. Firefox installations from the DNF Package Manager doesn't actually have an updater. Therefore the error messages you're seeing are updater warnings that shouldn't actually be displayed. I'll make a patch to address this.

Comment 6

[Eric Chen]

Attachment: Bug 1928508 - Guard update.locale missing error message with updater existence check r=nalexander!

Comment 7

[Eric Chen]

:Eemeli, should we be packaging the update.locale file even when the Firefox installation doesn't have an updater?

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a37c1aa53d1c
Guard update.locale missing error message with updater existence check r=nalexander

Comment 9

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/a37c1aa53d1c

Comment 10

[Eemeli Aro [:eemeli]]

Sorry for the delay in answering, I saw the patch landing after the needinfo, and incorrectly presumed that the question had been answered.

The only reason why we might want to include an update.locale file even if there's no updater is if bug 1391213 might apply (see discussion starting from comment 18); the fix for that also reads the file to determine the default locale.

Do we have any situation (via DNF or otherwise) where localized repack builds are made available without updater? If so, it might be better to rename the file to something like default.locale and always include it.

Comment 11

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

(In reply to Eemeli Aro [:eemeli] from comment #10)

Sorry for the delay in answering, I saw the patch landing after the needinfo, and incorrectly presumed that the question had been answered.

The only reason why we might want to include an update.locale file even if there's no updater is if bug 1391213 might apply (see discussion starting from comment 18); the fix for that also reads the file to determine the default locale.

Do we have any situation (via DNF or otherwise) where localized repack builds are made available without updater? If so, it might be better to rename the file to something like default.locale and always include it.

I wonder if the Android fat AARs are like that? They have lots of locales, don't ship the updater, and don't use langpacks (as opposed to MSIX repackages, which do use langpacks).

It sounds like we want to call this default.locale and just start including it more broadly, but I don't feel strongly about it.

Comment 12

[Eemeli Aro [:eemeli]]

I filed bug 1936528 for the rename, and while investigating also submitted bug 1936505 regarding locale.ini.