1936505 - Remove unused locale.ini and its generator

Status: RESOLVED FIXED

(Toolkit :: Default Browser Agent, defect)

Description

[Eemeli Aro [:eemeli]]

The parent bug 1826375 removed the last and only apparent use for locale.ini, a generated file added in bug 1621696. Despite its rather generic name, it seems to be specific to the Default Browser Agent, as noted by :nalexander at the time.

If/as the file and its generator have no more use, they should be removed.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1826375

:nrishel, since you are the author of the regressor, bug 1826375, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Nick Rishel [:nrishel]]

:eemeli did you look into this far enough to verify removing D73955 cleans this up? At the time I thought I had torn out the necessary bits but apparently not.

If you'd prefer I can take this on, but my guess is you already have a handle of what needs to be done?

Comment 3

[Eemeli Aro [:eemeli]]

I'd be very happy to have someone already familiar with the Default Browser Agent handle this, esp. as I don't have a Windows machine on which to test any changes.

As far as I can tell, the right fix here would be to remove the locale.ini generator and any references to the file. Those look like they were introduced in the patch you point to, but that patch also added some other .ini files with localizable content that was migrated to Fluent in bug 1854425. I've also not checked if some later references to locale.ini have been added later.

Comment 4

[Nick Rishel [:nrishel]]

Attachment: Bug 1936505 - Remove unused locale.ini generator. r=eemeli

Missed during Fluent migration in Bug 1854425.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9dc0146ca183
Remove unused locale.ini generator. r=eemeli

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/9dc0146ca183

Comment 7

[Mike Kaply [:mkaply]]

Apparently this was being used by enterprises to figure out what the default Firefox locale was.

Could we possibly move this information to another file like application.ini?

Comment 8

[Nick Rishel [:nrishel]]

:eemeli NI to field above question.

Comment 9

[Nick Alexander :nalexander [he/him]]

(In reply to Mike Kaply [:mkaply] from comment #7)

Apparently this was being used by enterprises to figure out what the default Firefox locale was.

Could we possibly move this information to another file like application.ini?

Surely we can, but do we want to? In the interim, suggest to fish omni.ja/default.locale in some way, noting that the omnijar is a ZIP archive.

Comment 10

[Mike Kaply [:mkaply]]

Eemili came up with:

unzip -p /Applications/Firefox.app/Contents/Resources/omni.ja default.locale 2>/dev/null

so that's going to be my recommendation. I'll open a new ticket if that can't solve folks' problem.

Comment 11

[Mike Kaply [:mkaply]]

We're good here. Eemili's method worked perfectly.