1936528 - Rename generated update.locale as default.locale

Status: RESOLVED FIXED

(Toolkit :: Application Update, task, P3)

Description

[Eemeli Aro [:eemeli]]

As we have occasional need for a generated file like update.locale beyond the updater (see linked bugs), it would be better to rename it as default.locale or otherwise indicate that it doesn't necessarily have a single purpose.

Comment 1

[Eemeli Aro [:eemeli]]

Attachment: Bug 1936528 - Rename generated update.locale as default.locale, always include it

Comment 2

[Eemeli Aro [:eemeli]]

Nick, I've filed a patch that should apply the rename, as well as always including the file, and submitted a try push. Would you know which try jobs could validate the fix?

Comment 3

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

(In reply to Eemeli Aro [:eemeli] from comment #2)

Nick, I've filed a patch that should apply the rename, as well as always including the file, and submitted a try push. Would you know which try jobs could validate the fix?

./mach try fuzzy toolkit/mozapps/update would run the update tests, which seem potentially impacted. After that, I think the l10n tests would exercise the functionality (if anything does).

I skimmed the patch and it looks sensible.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91fc143c1485
Rename generated update.locale as default.locale, always include it r=nalexander,geckoview-reviewers,browser-installer-reviewers,valentin,ohall

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/91fc143c1485