1929680 - Boolean preferences are not all reported to Glean

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Geoff Lankow (:darktrojan)]

We record boolean preference values in mail_preferences_boolean, which is a labeled_boolean type. We didn't specify the labels for the type, so we're limited to 16 labels, but we are recording about 100 preferences. If we do specify the labels we can have up to 100 of them. That's quickly not going to be enough, we should split this data up.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1929680 - Fix collection of boolean preferences on Glean. r=#thunderbird-reviewers

Comment 2

[Geoff Lankow (:darktrojan)]

Sancus, I'm changing (fixing) how this telemetry is collected but not collecting anything new. I don't think that requires a data review, let me know if you disagree.

Comment 3

[Andrei [:sancus]]

Nope, this doesn't require data review. Is that really the best way to handle it? We should complain about these arbitrary label limitations :)

Comment 4

[Magnus Melin [:mkmelin]]

(In reply to Geoff Lankow (:darktrojan) from comment #0)

We record boolean preference values in mail_preferences_boolean, which is a labeled_boolean type. We didn't specify the labels for the type, so we're limited to 16 labels, but we are recording about 100 preferences.

To avoid this issue, we're using type: labeled_string instead, since you can then have 4096 unspecified labels.
We do that already for e.g. for preferences_integer and I think it would be better to handle it this way here also.

Comment 5

[Geoff Lankow (:darktrojan)]

The docs say labeled_string has the same restriction.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dad4fd320b7d
Fix collection of boolean preferences on Glean. r=tobyp

Comment 7

[Geoff Lankow (:darktrojan)]

Comment on attachment 9436027 [details]
Bug 1929680 - Fix collection of boolean preferences on Glean. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: no impact
Testing completed (on c-c, etc.): landed 3 days ago, I've verified that the data is now being submitted properly
Risk to taking this patch (and alternatives if risky): low

Comment 8

[Corey Bryant]

Comment on attachment 9436027 [details]
Bug 1929680 - Fix collection of boolean preferences on Glean. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 9

[Corey Bryant]

Thunderbird 133.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/d619cbf3ed3a

Comment 10

[Geoff Lankow (:darktrojan)]

Comment on attachment 9436027 [details]
Bug 1929680 - Fix collection of boolean preferences on Glean. r=#thunderbird-reviewers

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: This is to correct the probe uplifted in bug 1954442 so that it matches what's on the other channels.
  https://hg.mozilla.org/releases/comm-esr128/rev/a35fb15bd7e18c7723f09e7fbfbd998dadf5ac3d
• User impact if declined:
• Is this code covered by automated tests?: No
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: Yes
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed:

Comment 11

[Daniel Darnell [:dandarnell]]

Thunderbird 128.9.0esr:
https://hg.mozilla.org/releases/comm-esr128/rev/7fb2ffcb8534
https://hg.mozilla.org/releases/comm-esr128/rev/ac4a25a5a9f0

Comment 12

[Corey Bryant]

Comment on attachment 9436027 [details]
Bug 1929680 - Fix collection of boolean preferences on Glean. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr128