1932019 - in-app notifications: Load notifications from dynamic URL

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Toby Pilling [:tobyp]]

If the URL contains placeholder %VARS% such as %LOCALE%, those should be replaced with values from client and the notifications should be fetched from the constructed URL

Here's an example:
https://notifications.thunderbird.net/%LOCALE%/notifications.json

Comment 1

[Toby Pilling [:tobyp]]

Without this approach, l10n will become difficult to maintain and the one file will become bloated very quickly.

Comment 2

[Martin Giger [:freaktechnik]]

We'll also have to invalidate our cache on locale change then.

Comment 3

[Martin Giger [:freaktechnik]]

Attachment: Bug 1932019 - Use URL formatting for in app notifications update URL. r=arschmitz

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ed6a62bf1365
Use URL formatting for in app notifications update URL. r=arschmitz

Comment 5

[Martin Giger [:freaktechnik]]

Comment on attachment 9439469 [details]
Bug 1932019 - Use URL formatting for in app notifications update URL. r=arschmitz

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: At the moment, none.
Testing completed (on c-c, etc.): Automated tests
Risk to taking this patch (and alternatives if risky): Low risk, adds well established url formatting step to the update url for in-app notifications. Worst case updating would be broken for them.

Comment 6

[Corey Bryant]

Comment on attachment 9439469 [details]
Bug 1932019 - Use URL formatting for in app notifications update URL. r=arschmitz

[Triage Comment]
Approved for beta

Comment 7

[Corey Bryant]

Thunderbird 134.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/11beba47a50c

Comment 8

[Martin Giger [:freaktechnik]]

Uplifted to ESR in bug 1936307