193511 - post_bug page has two headers

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Gervase Markham [:gerv]]

This is fallout from bug 191087. When you submit a bug, the resulting page has
two headers. This is because results.html.tmpl, which is used for posting bugs
as well as processing them, checks for header_done and, if it's not set, prints
a header. However, created.html.tmpl does not set header_done.

Gerv

Comment 1

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Trivial patch.

Gerv

Comment 2

[Dave Miller [:justdave]]

Comment on attachment 114582 [details] [diff] [review]
Patch v.1

maybe header.html.tmpl and process/header.html.tmpl should set header_done
within them?

Comment 3

[Tobias Burnus]

Comment on attachment 114582 [details] [diff] [review]
Patch v.1

I think this a fallout from bug 193286 not from bug 191087.

Comment 4

[Tobias Burnus]

> maybe header.html.tmpl and process/header.html.tmpl should set header_done
> within them?
Sounds reasonable. It would be nice if we could get rid of constructs like
    $::template->process("global/header.html.tmpl", $::vars)
      || ThrowTemplateError($::template->error());
    $vars->{'header_done'} = 1;
but then we would need to pass the var as reference.

How about checking this in for 2.17.4 and then afterwards investigating whether
we can set it in */header.html.tmpl and remove setting header_done in all other
places.

Comment 5

[Gervase Markham [:gerv]]

Yes, setting header_done in the template is the obvious thing. I thought of
that, but as the patch was much bigger, thought we'd get this fix in first.

$::vars is a reference already, so we have no problems there.

Gerv

Comment 6

[Gervase Markham [:gerv]]

Requesting approval.

Gerv

Comment 7

[Gervase Markham [:gerv]]

Is it worth fixing header_done to work "right" when bbaetz is bent on
eliminating it altogther?

Fixed.

Checking in template/en/default/bug/create/created.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/created.html.tmpl,v
 <--  created.html.tmpl
new revision: 1.6; previous revision: 1.5
done

Gerv

Comment 8

[Bradley Baetz (:bbaetz)]

Well, I haven't decied if I plan to remove it entirely.

Note that I did manage to do so for show_bug when I rewrote that, so its not
impossible. It may require process_bug to be rewritten first, mind you