1935716 - Unified search button UI is broken with browser.urlbar.usb.dynamic set to false

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Petruta Horea [:phorea], Desktop Test Engineering]

Attachment: light/dark theme

Notes

• Does not reproduce with browser.urlbar.usb.dynamic = true

Found in

• Nightly 135.0a1;

Affected versions

• Nightly 135.0a1;

Affected platforms

• Windows 10/11;
• Ubuntu 22;
• macOS 14;

Preconditions

• browser.urlbar.usb.dynamic set to false
• browser.urlbar.scotchBonnet.override set to true (default)

Steps to reproduce

1. Launch Firefox.
2. Open Unified Search button, select any search engine from the dropdown.
3. Input a string and submit the search.

Expected result

• Consistent UI.

Actual result

• Broken UI, please see the attached screenshot attached.

Regression range

• regressed by: bug 1928132

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:daisuke, since you are the author of the regressor, bug 1928132, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Daisuke Akatsuka (:daisuke)]

Thank you very much for the report!
I also could reproduce this issue.
I will take a look.

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1935716: Apply search mode chicklet color to the switcher when searchmode

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36b529b18042
Apply search mode chicklet color to the switcher when searchmode r=desktop-theme-reviewers,urlbar-reviewers,dao

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/36b529b18042

Comment 6

[Petruta Horea [:phorea], Desktop Test Engineering]

Hi Daisuke!
Unfortunately, this issue still reproduces on latest Nightly 135.0a1 (2024-12-11) and now it also occurs before submitting the search by entering search mode and a string in urlbar and then clicking bellow the address bar.

Comment 7

[Daisuke Akatsuka (:daisuke)]

Thank you very much for the report, Petruta!
If possible, would you mind filing this as a new bug?