1936040 - Crash in [@ java.lang.RuntimeException: at androidx.coordinatorlayout.widget.DirectedAcyclicGraph.dfs(DirectedAcyclicGraph.java)]

Status: RESOLVED FIXED

(Firefox for Android :: General, defect)

Description

[Andrew McCreight [:mccr8]]

Crash report: https://crash-stats.mozilla.org/report/index/c9d9a881-249a-4346-9bbd-0a6170241209

Top 10 frames:

0  androidx.coordinatorlayout.widget.DirectedAcyclicGraph  dfs  DirectedAcyclicGraph.java:55
1  androidx.coordinatorlayout.widget.DirectedAcyclicGraph  dfs  DirectedAcyclicGraph.java:38
2  androidx.coordinatorlayout.widget.DirectedAcyclicGraph  dfs  DirectedAcyclicGraph.java:38
3  androidx.coordinatorlayout.widget.DirectedAcyclicGraph  dfs  DirectedAcyclicGraph.java:38
4  androidx.coordinatorlayout.widget.CoordinatorLayout  prepareChildren  CoordinatorLayout.java:386
5  androidx.coordinatorlayout.widget.CoordinatorLayout  onMeasure  CoordinatorLayout.java:4
6  android.view.View  measure  View.java:27557
7  androidx.constraintlayout.widget.ConstraintLayout$Measurer  measure  ConstraintLayout.java:573
8  androidx.constraintlayout.core.widgets.ConstraintWidgetContainer  measure  ConstraintWidgetContainer.java:47
9  androidx.constraintlayout.core.widgets.ConstraintWidgetContainer  layout  ConstraintWidgetContainer.java:138

A very large crash spike on this signature was fixed a few months ago in bug 1917138, but it looks like it has started appearing in the Nightly build again, in 20241204215713.

Comment 1

[Andrew McCreight [:mccr8]]

[Tracking Requested - why for this release]: For Android Nightly, this crash volume is pretty high.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

First cut at a regression range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=924fc2b70c083b74e30a91efc81fce66aefccea1&tochange=9a8cc59e9dab76401127b07ca3f22a8cc7334b94

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Lots of breadcrumbs regarding login prompts. Regression from bug 1933478 maybe?

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 10 AArch64 and ARM crashes on nightly

For more information, please visit BugBot documentation.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox135 (nightly). However, the bug still isn't assigned.

:rsainani, could you please find an assignee for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

This is the #1 topcrash for Fenix Nightly at the moment. Can we please find an assignee for this?

Comment 7

[Alexandra Virvara]

I am investigating this.

Comment 8

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1936040 - Avoid setting dependencies through LoginSelectBarBehavior r=#android-reviewers

Speculative fix for a crash from cycling dependencies in the layout.

Comment 9

[Petru-Mugurel Lingurar [:petru]]

Could not reproduce and don't know if the changes from bug 1909746 caused this on their own but I think the above patch should help avoid the issue.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/452281fb9a8c
Avoid setting dependencies through LoginSelectBarBehavior r=android-reviewers,avirvara

Comment 11

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/452281fb9a8c