1936548 - Redundant Show password option in the Save password doorhanger

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect)

Description

[Anca Soncutean, Desktop QA]

Attachment: Screenshot issue.png

Found in

• 135.0a1

Affected versions

• 135.0a1
• 134.0b8
• 133.0

Tested platform

• Windows 11
• macOS 13

Steps to reproduce

1. Go to https://www.facebook.com/
2. Enter a username and a password and click Log In
3. Observe the Save password doorhanger

Expected result

• Only the show/hide password eye toggle icon should be present inside the Save password doorhanger.

Actual result

• There are two options to reveal the password: the "Show password" checkbox and the eye toggle icon within the password field.

Regression range

• https://bugzilla.mozilla.org/show_bug.cgi?id=1750072

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:mtigley, since you are the author of the regressor, bug 1750072, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1936548 - Remove show password checkbox from passwordmgr doorhanger. r=#credential-management-reviewers

Effectively superseded by the show password icon in the input field.

Arguably, the checkbox's logic was a bit more subtle, but I don't think
it matters much in practice. All chrome doc input fields show the show
password icon nowadays.

Comment 3

[Donal Meehan [:dmeehan]]

Updating the affected versions.
The regressor bug 1750072 has a leave-open keyword, but the last patch landed in Fx127?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/800c1337300c
Remove show password checkbox from passwordmgr doorhanger. r=credential-management-reviewers,desktop-theme-reviewers,hjones,mtigley

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/800c1337300c

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox135 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

I have reproduced the issue with Firefox Nightly 135.0a1 from 2024-12-11, using Windows 11.
Verified as fixed using Firefox 136.0b5 on Windows 11, macOS 14.7 and Ubuntu 22.04. Only the show/hide password eye toggle icon is now present inside the Save password doorhanger.