1936940 - Implementation bug for dialog light dismiss behavior

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Mason Freed]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/133.0.0.0 Safari/537.36

Steps to reproduce:

This is an implementation bug for the new light dismiss behaviors (including closedby attribute and dialog.requestclose()) proposed here:

https://github.com/whatwg/html/pull/10737

Comment 1

[Francesco Lodolo [:flod]]

(please move if there is a better component)

Comment 2

[Keith Cirkel [:keithamus]]

Attachment: Bug 1936940 - Implement dialog light dismiss r?#dom-core

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/307ff391dd02
Implement dialog light dismiss r=webidl,emilio

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/52263 for changes under testing/web-platform/tests

Comment 5

[amarc]

Backed out for causing wpt failures @ dialog-closedby.html

• Backout link
• Push with failures
• Failure Log
• TV Failure log

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5ea16162b91
Implement dialog light dismiss r=webidl,emilio

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b24cb4c73de
Revert "Bug 1936940 - Implement dialog light dismiss r=webidl,emilio" for failing two html/semantics/interactive-elements/the-dialog-element/ tests

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing two html/semantics/interactive-elements/the-dialog-element/ tests:
https://hg.mozilla.org/integration/autoland/rev/4b24cb4c73de071263079dd4923d58dc7daf0247

Push with failures
Failure log

TEST-UNEXPECTED-FAIL | /html/semantics/interactive-elements/the-dialog-element/dialog-closedby.html | assertion count 2 is more than expected 0 assertions
TEST-UNEXPECTED-FAIL | /html/semantics/interactive-elements/the-dialog-element/dialog-requestclose.html | assertion count 46 is more than expected 0 assertions

Comment 10

[Keith Cirkel [:keithamus]]

Thanks, looks like I hit some rebase errors or something, as some intentional lines got removed. Third time lucky!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8e3c757908e
Implement dialog light dismiss r=webidl,emilio

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b8e3c757908e

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/52303 for changes under testing/web-platform/tests

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot