1964029 - [perma] comm/mail/components/addrbook/test/browser/browser_edit_photo.js | Uncaught exception in test bound test_local - waiting for photo dialog to change state - timed out after 50 tries

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mkmelin [at] iki.fi
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=506447493&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/CkFInKs7QUeNS4PAuAFzeQ/runs/0/artifacts/public/logs/live_backing.log

---

Comment 1

[Magnus Melin [:mkmelin]]

m-c regression range: https://hg-edge.mozilla.org/mozilla-central/pushloghtml?changeset=5b5bd7e730096ef3867efe107dc97fb4a38a489a

Comment 2

[Magnus Melin [:mkmelin]]

"Person with photo" is not showing the photo. https://firefoxci.taskcluster-artifacts.net/bySyTrK1SAWuvSP0ML30DQ/0/public/test_info/mozilla-test-fail-screenshot_7ii3oepx.png

Comment 3

[Magnus Melin [:mkmelin]]

Definitely something from m-c that broke it.

Comment 4

[Martin Giger [:freaktechnik]]

Based on how it's failing I wouldn't be surprised if it's bug 1963446 or possibly bug 1936940

Comment 5

[Martin Giger [:freaktechnik]]

I think what's changed is that escape is canceling the contact editing instead of just closing the contact photo dialog?

Comment 6

[Martin Giger [:freaktechnik]]

Confirmed, it's bug 1936940 that changes how the escape keypress propagates, leading to use closing the edit form, which breaks the test.

Comment 7

[Magnus Melin [:mkmelin]]

Thanks! Martin, are you looking at fixing it?
If not, Alex can you take a look?

Comment 8

[Martin Giger [:freaktechnik]]

I'm not sure if this is something we should fix or if it's an unintended regression from bug 1936940. I haven't looked into what the expected behavior is though.

Comment 9

[Magnus Melin [:mkmelin]]

Esc handling for the address book form is at https://searchfox.org/comm-central/rev/7cf8218b74a7799d6f8e8b322ddccb52afda1b06/mail/components/addrbook/content/aboutAddressBook.js#2580

Comment 10

[Intermittent Failures Robot]

16 failures were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 16

Table

	no_variant
linux1804-64-qr--/opt	2
linux1804-64-qr--/debug	1
macosx1015-64-qr--/opt	3
macosx1015-64-qr--/debug	1
macosx1470-64--/opt	3
macosx1470-64--/debug	1
windows11-32-24h2--/opt	3
windows11-32-24h2--/debug	1
windows11-64-24h2--/debug	1

For more details, see:

https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1964029&startday=2025-04-28&endday=2025-05-04&tree=all

Comment 11

[Magnus Melin [:mkmelin]]

I would have thought we could work around it by adding closedby="none" to the dialog. But even with that, Esc will close the dialog. Is that expected?

Comment 12

[Keith Cirkel [:keithamus]]

You’ll need the flag enabled for that to work. If the flag is not enabled and behaviour has changed this may be a regression. I’ll investigate further.

Comment 13

[Magnus Melin [:mkmelin]]

Right dom.dialog.light-dismiss.enabled is not enabled yet.
What seems to have changed is that earlier Esc would close the dialog, and that would be it - no Esc keypress event seen. But now we see one.

Comment 14

[Intermittent Failures Robot]

22 failures were associated with this bug yesterday.

Repository breakdown:

• comm-central: 22

Table

	msix	no_variant
linux1804-64-ccov-qr--/opt		2
linux1804-64-qr--/debug		1
linux1804-64-qr--/opt		3
macosx1015-64-qr--/debug		2
macosx1015-64-qr--/opt		2
macosx1470-64--/debug		1
macosx1470-64--/opt		2
windows11-32-24h2--/debug		1
windows11-32-24h2--/opt		2
windows11-64-24h2--/debug	1	1
windows11-64-24h2--/opt	2	2

For more details, see:

https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1964029&startday=2025-05-05&endday=2025-05-05&tree=all

Comment 15

[Keith Cirkel [:keithamus]]

Attachment: WIP: Bug 1964029 - Close dialogs on escape after a tick

Comment 16

[Keith Cirkel [:keithamus]]

Attachment: Bug 1964029 - Close dialogs on escape after a tick r?#dom-core

Comment 17

[Intermittent Failures Robot]

21 failures were associated with this bug yesterday.

Repository breakdown:

• comm-central: 21

Table

	msix	no_variant
linux1804-64-ccov-qr--/opt		1
linux1804-64-qr--/debug		1
linux1804-64-qr--/opt		3
macosx1015-64-qr--/debug		1
macosx1015-64-qr--/opt		2
macosx1470-64--/debug		1
macosx1470-64--/opt		2
windows11-32-24h2--/debug		1
windows11-32-24h2--/opt		2
windows11-64-24h2--/debug	1	1
windows11-64-24h2--/opt	2	2
windows11-64-24h2--/asan		1

For more details, see:

https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1964029&startday=2025-05-06&endday=2025-05-06&tree=all

Comment 18

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1936940

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/619600ddb585
Close dialogs on escape after a tick r=dom-core,edgar

Comment 20

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/619600ddb585

Comment 21

[Magnus Melin [:mkmelin]]

This fixed this failure. But unfortunately the failure is back after just a day - probably from bug 1965052. Filed bug 1965654

Comment 22

[Intermittent Failures Robot]

114 failures were associated with this bug in the last 7 days.
This is the #10 most frequent failure this week.

This failure happened more than 75 times this week! Resolving this bug is a very high priority.

Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled.

Repository breakdown:

• comm-central: 102
• try-comm-central: 12

Table

	msix	no_variant
linux1804-x86_64/ccov		6
linux1804-x86_64/debug		5
linux1804-x86_64/opt		15
linux1804-x86_64/tsan		2
macosx1015-x86_64/debug		7
macosx1015-x86_64/opt		10
macosx1470-x86_64/debug		6
macosx1470-x86_64/opt		10
windows11-x86/debug		7
windows11-x86/opt		11
windows11-x86_64/asan		2
windows11-x86_64/ccov		1
windows11-x86_64/debug	6	6
windows11-x86_64/opt	10	10

For more details, see:

https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1964029&startday=2025-05-05&endday=2025-05-11&tree=all