Consider updating settings panel supported sites in the auto-open toggle description
Categories
(Firefox Graveyard :: Shopping, task, P2)
Tracking
(Not tracked)
People
(Reporter: kpatenio, Unassigned)
References
Details
(Whiteboard: [fidefe-RCSidebar])
Currently, we update the settings panel description for the auto-open toggle, depending on the currently viewed site: https://searchfox.org/mozilla-central/rev/2493c256dbff4e3c7e51a7fc61115df887b87e9e/browser/components/shopping/content/settings.mjs#112. For instance, if we're viewing the panel under amazon.de, we will only refer to Amazon. Opposite to this, if we view under amazon.com, we update the description to refer to Amazon, Best Buy and Walmart; this is because we assume users using de/fr will not have access to those sites, and only the de/fr version of Amazon.
My patch for Bug 1916012 does two things:
- passes information from our ProductConfig, so that we know which domains are supported
- lists all supported domains in one of the empty states, even the de/fr ones. For now, we assume that all users will have access to RC in all of those domains.
Given this, we may want to update the string in the settings panel to be consistent with the changes above. It will also prevent a non-critical error that occurs when viewing the settings panel in a non-PDP / empty state for the integrated version of RC.
Updated•1 year ago
|
Just realized that we also check for sites in other components, like the analysis-explainer, for instance. Fortunately, we already have a version that doesn't mention the sitename if we're unable to read the product URL (ex. empty states, non PDPs). We might similarly want to make use of the getSupportedDomains to simplify these steps.
Comment 2•1 year ago
|
||
This bug is being closed because we are closing the Bugzilla component.
If this still needs attention, please re-open and change component to
the appropriate component or "General".
Updated•1 year ago
|
Description
•