Closed Bug 1950471 Opened 1 year ago Closed 1 year ago

Update settingsTemplate to get hostname for supported domains rather than just product pages

Categories

(Firefox Graveyard :: Shopping, defect)

defect

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: rking, Unassigned)

References

Details

Attachments

(2 files)

Currently, settingsTemplate derives hostname from this.getHostnameFromProductUrl(), which returns null on a non-product page, even if the domain is supported.
https://searchfox.org/mozilla-central/source/browser/components/shopping/content/shopping-container.mjs#594
https://searchfox.org/mozilla-central/source/browser/components/shopping/content/shopping-container.mjs#271

Because of this, the descriptions for auto-open and auto-close settings in Review Checker include the three sites language (Amazon, Best Buy, and Walmart) instead of the single site language intended for amazon.de and amazon.fr when on the domain but not on a product page.
https://searchfox.org/mozilla-central/source/browser/components/shopping/content/settings.mjs#128

On Amazon.de, the auto-open and auto-close settings descriptions list Amazon, Best Buy, and Walmart

On a product page on amazon.de, the auto-open and auto-close settings descriptions show only Amazon

See Also: → 1937924

The severity field is not set for this bug.
:jhirsch, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(jhirsch)
Severity: -- → S3
Flags: needinfo?(jhirsch)

This bug is being closed because we are closing the Bugzilla component.
If this still needs attention, please re-open and change component to
the appropriate component or "General".

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → INCOMPLETE
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: