1938392 - Add integratedSidebar pref to Nimbus

Status: VERIFIED FIXED

(Firefox Graveyard :: Shopping, task, P2)

Description

[Fred Chasen [:fchasen]]

We'll need to be able to control which sidebar is being used with Nimbus, so we will want to add browser.shopping.experience2023.integratedSidebar to the FeatureManifest.yaml

Comment 1

[Fred Chasen [:fchasen]]

Attachment: Bug 1938392 - Add integratedSidebar pref to Nimbus. r=#shopping-reviewers!

Adds the integratedSidebar pref to the shopping2023 Nimbus feature and separates the enabling prefs for the migrated Review Checker in the main sidebar and the Shopping sidebar.

• Updates browser.shopping.experience2023.integratedSidebar to be the only enabling pref for the migrated Review Checker sidebar.
• Prevents browser.shopping.experience2023.enabled from disabling the migrate sidebar and uses it as the pref for the ShoppingSidebar actors.
• Removes the browser.shopping.experience2023.shoppingSidebar pref as it is no longer needed.
• Updates any tests the used these prefs to the new use.
• Init's the two sidebar differently in ShoppingUtils based on the Nimbus prefs.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6f7ddb9661f
Add integratedSidebar pref to Nimbus. r=shopping-reviewers,firefox-desktop-core-reviewers ,sidebar-reviewers,mossop,Gijs,rking

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c6f7ddb9661f

Comment 4

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly 138.0a1 (2025-03-27) The browser.shopping.experience2023.shoppingSidebar pref is no longer displayed in our Nightly build