1950570 - Review Checker sidebar close button no longer works

Status: VERIFIED FIXED

(Firefox Graveyard :: Shopping, defect)

Description

[Kestrel]

STR:

1. Set sidebar.revamp = true and browser.shopping.experience2023.integratedSidebar = true.
2. Enable the "Review Checker" sidebar and open it.
3. Click the close button inside the sidebar.

Expected:
Sidebar closes.

Actual:
Nothing happens.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9d99276691fadfa3e296b120bba92cbb5b54c64f&tochange=b102183efb05db57ec69f0dae084718293a3b90d

Regressed by Bug 1921481.

Comment 1

[BugBot [:suhaib / :marco]]

:fchasen, since you are the author of the regressor, bug 1921481, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1921481

Comment 3

[Fred Chasen [:fchasen]]

I'm seeing the sidebar close and then reopen when the URL changes with a link like https://www.amazon.com/Play-Doh-Modeling-Compound-Non-Toxic-Exclusive/dp/B00JM5GW10/137-5724845-3498823?pcs=1 as &th=1 is added to the URL.

I'm marking this as a duplicate of Bug 1945049 which has a patch in progress to fix these URL issues.

Comment 4

[Kestrel]

Bug 1945049 sounds quite different since this happens for non-shopping sites and the sidebar does not respond at all to the close button being clicked, it is not being automatically reopened.

Comment 5

[Fred Chasen [:fchasen]]

Ah thanks, do you have more info on how to reproduce this? I'm not able to see what you described above.

• Do you have a link or two I should try this on?
• What OS are you seeing this with?
• Is RC on the opt-in screen when this happens?
• Does it happen when browser.shopping.experience2023.shoppingSidebar is set to false?

Comment 6

[kpatenio]

If you're able to attach a screen recording of the buggy behaviour in question, that would help us immensely as well.

Comment 7

[Kestrel]

Attachment: Cannot close integrated shopping sidebar with close button

This only happens with the integrated sidebar which requires setting browser.shopping.experience2023.integratedSidebar = true.

Comment 8

[Fred Chasen [:fchasen]]

Do you have browser.shopping.experience2023.enabled set to false? I'm able to reproduce the bug with that.

We should never have that combination of prefs set, but will update to make sure close still works for that.

Comment 9

[Kestrel]

Yes, it works with browser.shopping.experience2023.enabled = true.

Comment 10

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:jhirsch, could you have a look please?

For more information, please visit BugBot documentation.

Comment 11

[Fred Chasen [:fchasen]]

Enabled currently controls if the ReviewCheckerManager will be added to a window, so that pref will need to be true until the prefs cleanup patch lands for Bug 1938392.

Comment 12

[Pascal Chevrel (relman team) -> :pascalc]

Fred, did you really want to mark this bug as P1/S1?

Comment 13

[Fred Chasen [:fchasen]]

Ek, no I did not!

Comment 14

[Fred Chasen [:fchasen]]

The enabled pref now longer control the new RC sidebar, so the close button will work independently of this now.

Comment 15

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly builds 139.0a1 (2025-04-01)