1941531 - Windows: Thunderbird doesn't update with Restart button in About dialog

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Richard Marti (:Paenglab)]

On Windows when a update is available for Daily I can download the upgrade. When I use the Restart button in about dialog it says "Applying update" and then restarts. Checking then the about dialog it says "Restart to upgrade". No matter how many times I press the button and Daily restarts, this button stays.

I have to close/reopen Daily to update. The about dialog says then that it's the actual version.

It seems restart with the restart button in about dialog doesn't close Daily fully to apply the upgrade. Only closing Daily stops all processes.

Geoff thinks it could be a regression from bug 1907127.

I added now the prefs app.update.multiSessionInstallLockout.enabled and app.update.multiSessionInstallLockout.timeoutMs to my Daily profile. I'll see if this could solve the upgrade issue.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug 1941531 - Port bug 1907127: Add support for writing update.timestamp. r=#thunderbird-reviewers

Comment 2

[Richard Marti (:Paenglab)]

Yes, setting this prefs fixed the update issue.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a1d2dbe1b98f
Port bug 1907127: Add support for writing update.timestamp. r=mkmelin

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 9459826 [details]
Bug 1941531 - Port bug 1907127: Add support for writing update.timestamp. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): Bug 1907127
User impact if declined: on Windows update does not work through about dialog
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low, regressing bug is on 135

Comment 5

[Corey Bryant]

Comment on attachment 9459826 [details]
Bug 1941531 - Port bug 1907127: Add support for writing update.timestamp. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 6

[Daniel Darnell [:dandarnell]]

Thunderbird 135.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/f62ac2557b4f

Comment 7

[Corey Bryant]

Reopening due to a user report that they are hitting this on 135.0b3 on Windows.

Comment 8

[Richard Marti (:Paenglab)]

It can be that it will work with the next update after this patch landed on beta. The prefs have to be written first to be used during the update.

Comment 9

[doug2]

Downloaded 135.0b3 (manually) and used the "restart to update" in About to update, but after update, the About box still showed click to update. (Win 11, en-US) Clicked to update (again) and after TB restart, About box still showed click to update.

Comment 10

[Richard Marti (:Paenglab)]

Important is what happens when updating from b3 to b4 as the fix landed on b3.

Comment 11

[Richard Marti (:Paenglab)]

Updated from b3 to b4 and the restart applied the update.