1941702 - Going back to a previously opened folder can cause the selection to be restored twice

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Geoff Lankow (:darktrojan)]

When returning to a folder that's already been opened in the current session, the selection is restored. In some cases this happens two or more times as the messages load (once for each dbViewWrapperListener.onMessagesLoaded call). But even if restoreSelection doesn't change the selection, it still results in a "select" event and the message pane reloads (again). This shouldn't happen.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1941702 - When restoring the selection, don't say the selection changed if it didn't. r=welpy-cw,#thunderbird-front-end-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dcf9199935b8
If a message is displayed, refuse to load it again. r=aleca,welpy-cw

Comment 3

[Geoff Lankow (:darktrojan)]

This causes a memory leak by preventing the message pane from reloading after a folder compact. browser_messageCommandsOnMsgstore.js is failing with this leak. I'm going to back it out and try a different approach.

Comment 4

[Geoff Lankow (:darktrojan)]

Backed out:
https://hg.mozilla.org/comm-central/rev/6569a1d14682202b58b974ae2d481032d693dcb1

Let's try again.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/eeceba60a888
When restoring the selection, don't say the selection changed if it didn't. r=welpy-cw,aleca