194319 - Bookmark Menu won't scroll with Dragged URL (also Personal Toolbar)

Status: NEW

(Core :: XUL, defect)

Description

[Ed Lana]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.3b) Gecko/20030217
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.3b) Gecko/20030217

Neither the Bookmark Menu or the Personal Toolbar menu scroll when a URL is
dragged to their respective drop down menus.

Reproducible: Always

Steps to Reproduce:
How to Reproduce

Step #1 Have a book mark folder or personal bookmark folder with enough entries
to require you to scroll the bookmark list to see them all.

Step #2 Drag the URL handle from the URL Address Bar to the bookmark drop down
menu and attempt to scroll down the bookmark list.
Actual Results:  
Result: You can't scroll


Expected Results:  
The Bookmark list would scroll when the dragged object was over the up or down
arrow on the drop down list.

OS: Win98SE
Mozilla: 1.3b 2003021704

This may be related to bug 139403 but because it is outside of the original
description of the problem I am submitting it as a separate bug.

Comment 1

[Andreas Kunz]

The same with post-1.4a Trunk build on Win2k.
-> NEW

Comment 2

[Graeme Hackston]

I'm using the same OS as the original report with identical problems and
frequency in versions 1.0 through 1.4.

Bookmark can't be dragged up or down from the presently viewable area in a
personal toolbar folder drop down.  If I try to pre-scroll the drop down before
dragging a URL, I can only drop the bookmark by itself, not in a folder.

If it matters, I moved the bookmarks from NN4.74.  I can't recall what I did but
I remember having issues setting up the personal toolbar folder in version 1.0
Is there a guide somewhere for installing NN4 bookmarks so that I can try a
clean install?

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Mass reassign of my non-Firefox bugs to [e-mail]

Comment 4

[Søren Thing Pedersen]

Reproduced in 1.6 for Windows.

I suggest a nomination as possible 1.7 final blocker.

Comment 5

[Asa Dotzler [:asa]]

When did this regress? If it's never worked then it's unlikely to make it for
1.7 final. If a well tested and fully reviewed patch happens in time for final,
please request approval to land. Not going to block the release for this change.

Comment 6

[R.K.Aa.]

*** Bug 238459 has been marked as a duplicate of this bug. ***

Comment 7

[hachiro]

Attachment: patch

This patch should be applied also to 
xpfe/global/resources/content/bindings/scrollbox.xml

this is solvable even if you do not have a compiler.
just unzip your mozilla/toolkit.jar, edit scrollbox.xml
as well as this patch, and zip it again.

Comment 8

[Andreas Kunz]

Comment on attachment 150120 [details] [diff] [review]
patch

hachiro:
Well, this bug is not about Firefox, but the Mozilla suite. But let's not get
too bureaucratic, at least right now...
However, you have to ask a specific person for review or you'll never get it.
I'll choose mconnor for that.
(note: I have not tested this patch)

Comment 9

[Andreas Kunz]

Attachment: equivalent patch for seamonkey

This is the same patch for the seamonkey file. Works, but not fully tested.
Scrolling is pretty fast... maybe even as fast as the CPU allows??
Autoscrolling in trees e.g. uses a scroll callback and timer...

hachiro:
did you have a specific reason for letting the event bubble (which is prevented
when the user clicks the scroll arrow) - or is it more like "well, it does
work..." ?
(I'm not saying you should not, just wondering)
And am I wrong when I think
   ondragover="this.parentNode.scrollByIndex(1);"
makes it scroll as fast as possible? What about faster machines in two years?
Won't they possibly scroll too fast?

Comment 10

[hachiro]

(In reply to comment #9)
> hachiro:
> did you have a specific reason for letting the event bubble (which is prevented
> when the user clicks the scroll arrow) - or is it more like "well, it does
> work..." ?
> (I'm not saying you should not, just wondering)
> And am I wrong when I think
>    ondragover="this.parentNode.scrollByIndex(1);"
> makes it scroll as fast as possible? What about faster machines in two years?
> Won't they possibly scroll too fast?

I should have tested it in more cases.
There's no specific reason why I didn't add preventBubble.
(maybe, I didn't know about event mechanism well)

What is worse, several bugs surfaced after posting a patch here.

1.Folders never open unless bookmarks-menu show its head portion.
2.bookmarks-menu closes soon after few scrolling in my Firefox(0.8 linux). 

Now, I'm trying to fix these new bugs (and too fast scrolling).
I'm hoping to post a patch again that fixes these bugs.

Comment 11

[Mike Connor [:mconnor]]

Comment on attachment 150120 [details] [diff] [review]
patch

based on subsequent comments, I'm going to minus this for now.	let me know if
you get a better solution.

Comment 12

[:Gavin Sharp [email: [e-mail]]]

*** Bug 213094 has been marked as a duplicate of this bug. ***

Comment 13

[:Gavin Sharp [email: [e-mail]]]

Attachment: Add preventBubble (Firefox)

Adding the preventBubble, I see none of the effects mentioned earlier. The fast
scrolling can be tackled in another bug if needed, it shouldn't hold this one
up since regular scrolling is that fast now anyways.

Comment 14

[:Gavin Sharp [email: [e-mail]]]

Attachment: Add preventBubble (Seamonkey)

Same for the Suite. I have no clue who I should ask for review.

Comment 15

[:Gavin Sharp [email: [e-mail]]]

Oh, and Andreas, hachiro, I'd appreciate if you could test this version as you
did the others. It seems to work fine for me on Windows.

Comment 16

[:Gavin Sharp [email: [e-mail]]]

*** Bug 276169 has been marked as a duplicate of this bug. ***

Comment 17

[bugz9]

In addition to fixing this Bug,  how about taking the initiative and either
adding new Bookmarks at the top of the list or adding an item to the right click
menu for a selected bookmark entry to "Move To Top" and "Move To Bottom", or both ?
A feature you would have, that is Important, that Microsoft does not have in
Internet Explorer 6.

Comment 18

[OstGote!]

(In reply to comment #14)
> Add preventBubble (Seamonkey)
> 
> Same for the Suite. I have no clue who I should ask for review.

Ask neil.parkwaycc.co.uk or timeless (if not they can help I guess).

Comment 19

[[e-mail]]

I'd prefer a tweak to nsScrollBoxObject.cpp's nsAutoRepeatBoxFrame::HandleEvent
although I don't know the difference between NS_DRAG_EXIT and NS_DRAG_EXIT_SYNTH

Comment 20

[Martijn Wargers (dead)]

Note that an eventuel solution that uses timers, won't work in windows, because
of bug 203573.
Maybe a workaround would be to check for how much time has elapsed?

Comment 21

[Richard Gibson]

Attachment: patch in nsAutoRepeatBoxFrame::HandleEvent

This patch does not work in Windows because of bug 203573, but I think the logic is sound.  Could someone please test with Linux and/or Mac?

P.S. NS_DRAG_EXIT and NS_DRAG_EXIT_SYNTH are defined to have the same value in http://lxr.mozilla.org/mozilla/source/widget/public/nsGUIEvent.h#262 (revision 3.125).

P.P.S. I have written an extension to fix this problem without timers.  It's a hack and doesn't really belong in the source, but should tide everyone over until this bug is fixed (and bug 203573, in the case of Windows users).  It will be available from https://addons.mozilla.org/extensions/moreinfo.php?id=1411 shortly, pending approval there.

Comment 22

[Wayne Mery (:wsmwk)]

How does the patch in bug 240709 fit in?

Comment 23

[(not reading, please use [e-mail] instead)]

> P.S. NS_DRAG_EXIT and NS_DRAG_EXIT_SYNTH are defined to have the same value in
> http://lxr.mozilla.org/mozilla/source/widget/public/nsGUIEvent.h#262 (revision
> 3.125).

richard, because of the same value issue, I had to remove the NS_DRAG_EXIT_SYNTH case in order for your patch to build on mac os x.

I'm rebuilding my tree now to see if your patch fixes an issue I was running into (on the mac) for my patch in bug #318168

Comment 24

[Andy Boze]

I don't know whether this will be of any consequence, but I applied patch 169683 [Add preventBubble (Seamonkey)] to SeaMonkey 1.5a nightly 20060830 on WinXP Pro, and it seems to be working great for me.

Comment 26

[Wayne Mery (:wsmwk)]

Andy in comment #24
> I applied patch 169683 [Add preventBubble (Seamonkey)] to SeaMonkey 1.5a nightly 20060830 on
> WinXP Pro, and it seems to be working great for me.

still fails 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a3pre) Gecko/20070314 SeaMonkey/1.5a

Comment 27

[Tracy Hall Jr]

In the previous release I could work around this bug by pre-scrolling the menu and then dragging the URL to the desired folder in the pre-scrolled menu. But release 2.0.0.6 now prevents pre-scrolling of the menu (it always returns to its original state.) So in 2.0.0.6 there is no work-around to this bug, thereby *making it worse.*

I'm not sophisticated enough to figure out how to install a patch. I hope that this *bug made worse by a new release* (the first Mozilla bug I have ever reported) will get some higher priority.

As requested, on Aug 25 2007 I installed the latest overnight to see if the bug has been fixed, - but the current version of Minefield is worse still: dragging a URL to the bookmark folder does not cause the folder to open at all!

Comment 28

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b4pre) Gecko/2008022601 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

Bug still there.


[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b4pre) Gecko/2008022702 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

This has probably been fixed by bug 389931,
but bug 419740 regression prevents checking this for now.

Comment 29

[Martijn Wargers (dead)]

As I also mentioned in bug 240709, comment 13, this is actually worksforme, except for the main bookmarks menu popup. For folder popups in the bookmarks menu, and sub-folders in the bookmarks menu, this is actually working now in current trunk build.

Comment 30

[Serge Gautherie (:sgautherie)]

(In reply to comment #28)
> but bug 419740 regression prevents checking this for now.

Let me be more explicit:

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b4pre) Gecko/2008022704 Minefield/3.0b4pre] (nightly) (W2Ksp4)

Bug 419740 is Firefox specific.

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b4pre) Gecko/2008022702 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

SeaMonkey has "similar" bug 420341.

*****

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b4pre) Gecko/2008022604 Minefield/3.0b4pre] (nightly) (W2Ksp4)

Before bug 389931 regressions (in Gecko/2008022704),
trying to drag a bookmark within a folder of the Personal Toolbar does scroll the folder,
as if the current bug had been already fixed, or worked around, (in Firefox) before that Core patch !
Does anyone know more about this ?

Comment 31

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

So you're saying that you think this bug is fixed, but you can't test because of another bug, and yet you're nominating *this* bug to block 1.9?  Why?

Comment 32

[Serge Gautherie (:sgautherie)]

(In reply to comment #29)
> As I also mentioned in bug 240709, comment 13, this is actually worksforme,

(Yes, I could confirm this in comment 30.)

> except for the main bookmarks menu popup. For folder popups in the bookmarks
> menu, and sub-folders in the bookmarks menu, this is actually working now in
> current trunk build.

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b4pre) Gecko/2008030305 Minefield/3.0b4pre] (nightly) (W2Ksp4)

Confirming:
*Folder in Personal Toolbar: scrolls.
*Bookmarks menu itself: does not scroll. (even after bug 418156, which fixed bug 419740)


[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.13pre) Gecko/2008030203 BonEcho/2.0.0.13pre] (nightly) (W2Ksp4)

FWIW, in the Bookmarks menu, when hovering the up/down arrows, FF v2 displays the forbidden pointer then closes the menu :-(

Comment 33

[Serge Gautherie (:sgautherie)]

(In reply to comment #31)
> So you're saying that you think this bug is fixed, but you can't test because
> of another bug, and yet you're nominating *this* bug to block 1.9?  Why?

Maybe it would be better to move bug 240709 from "Blocks" to "Depends on",
and make *it* "blocking1.9=?" !?

Comment 34

[eyal gruss]

works for me on firefox 3.6rc / 3.7a1pre

Comment 35

[Axel Grude [:realRaven]]

Same bug affects Thunderbird- so its definitely a Mozilla Core problem.

In my extension QuickFolders...
https://addons.mozilla.org/en-US/thunderbird/addon/3254
...you can drag emails onto popup menus that represent the folder tree, if the
list exceeds the screen the drag chevron does not scroll down the menu list.

See also https://www.mozdev.org/bugs/show_bug.cgi?id=21054

Comment 36

[Serge Gautherie (:sgautherie)]

(In reply to comment #34)
> works for me on firefox 3.6rc / 3.7a1pre

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.3a1pre) Gecko/20100116 Minefield/3.7a1pre] (nightly) (W2Ksp4)

Same as comment 32: can't test Bookmarks menu due to bug 428411.

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.3a1pre) Gecko/20100116 SeaMonkey/2.1a1pre] (nightly) (W2Ksp4)

Still doesn't work at all.

Comment 37

[sjpschmid]

Fixing this bug would greatly improve the usefulness of the QuickFolders Add-on for Thunderbird.

Comment 38

[Axel Grude [:realRaven]]

I have integrated Richard's code from:
https://bugzilla.mozilla.org/show_bug.cgi?id=194319#c21

extension:
https://addons.mozilla.org/extensions/moreinfo.php?id=1411

...into QuickFolders, which now makes the bookmarks scroll as expected (TB3.0.3 / WinXP). It will be released with the next version (QF 1.8.9 or 1.9). 

In the meantime, a test version for QuickFolders users can be downloaded here:
https://www.mozdev.org/bugs/show_bug.cgi?id=21054#c26

please leave some comments there if it works for you.

Comment 39

[Martijn Wargers (dead)]

Fwiw, this bug is still worksforme.

Comment 40

[Andy Boze]

I hadn't tried this for a long time. It's now a worksforme.

User agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/15.0 Firefox/15.0a1 SeaMonkey/2.12a1
Build identifier: 20120602003006

Comment 41

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S4. However, the bug has 3 duplicates and 19 votes.
:enndeakin, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 42

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The last needinfo from me was triggered in error by recent activity on the bug. I'm clearing the needinfo since this is a very old bug and I don't know if it's still relevant.