1943391 - Initial entrypoint to detect preview reqeust and fetch content

Status: RESOLVED FIXED

(Core :: Machine Learning: General, enhancement)

Description

[Ed Lee :Mardak]

Set up handlers to detect link preview and basic fetch. Separate bug for UI and fetch logic, e.g., filtering or safe browsing. Behind a pref

Comment 1

[Ed Lee :Mardak]

given that we'll want to detect mouseover events on content links and grabbing page content with reader mode parsing, seems likely we'll introduce a new actor but could potentially reuse https://searchfox.org/mozilla-central/source/browser/components/genai/GenAIChild.sys.mjs

Comment 2

[Ed Lee :Mardak]

we might want to start splitting out a separate link preview related sys.mjs from GenAI.sys.mjs

https://searchfox.org/mozilla-central/rev/55706b888f91fffa6f045f7cbc1a7b1c34598292/browser/components/genai/moz.build#10-11

where we can scope it e.g., https://searchfox.org/mozilla-central/search?q=EXTRA_JS_MODULES.

Comment 3

[Tim Xia]

Attachment: Bug 1943391 - Initial entrypoint to detect preview reqeust - r=Mardak

• add LinkPreview.sys.mjs modules
• disable browser.ml.linkPreview.enabled by default

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/04574e76f8f5
Initial entrypoint to detect preview reqeust - r=Mardak,firefox-desktop-core-reviewers ,firefox-ai-ml-reviewers,mossop

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/04574e76f8f5

Comment 6

[Atila Butkovits]

Backed out for causing high frequency failures at browser_bannerClicking.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/41e3e436702d7efaafbeb0858d742bc2e9b08bac

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=windows%2C11%2Cx64%2Casan%2Cmochitests%2Ctest-windows11-64-24h2-asan%2Fopt-mochitest-browser-chrome%2Cbc9&revision=04574e76f8f58b2ae849fd02c4056c198b3a5023

Failure log: https://treeherder.mozilla.org/logviewer?job_id=497828391&repo=autoland&lineNumber=5578

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d7cf2733400
Initial entrypoint to detect preview reqeust - r=Mardak,firefox-desktop-core-reviewers ,firefox-ai-ml-reviewers,mossop

Comment 8

[Cosmin Sabou [:CosminS]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/41e3e436702d

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9d7cf2733400

Comment 10

[Cosmin Sabou [:CosminS]]

Backed out changeset 9d7cf2733400 (bug 1943391) for causing leaks on browser_tab_groups_closed.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&revision=091b3080e82c608b1eb30871530b63ca5b3bbad9&selectedTaskRun=EmTObaXbRMumMF07N3jXbw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=497909970&repo=autoland

Failure rate is in: https://treeherder.mozilla.org/intermittent-failures/bugdetails?startday=2025-02-28&endday=2025-03-07&tree=trunk&bug=1934803

Backout link: https://hg.mozilla.org/mozilla-central/rev/47503d9b7c97

Comment 11

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/47503d9b7c97
Backed out changeset 9d7cf2733400 for causing leaks on browser_tab_groups_closed.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78089a268b01
Initial entrypoint to detect preview reqeust - r=Mardak,firefox-desktop-core-reviewers ,firefox-ai-ml-reviewers,mossop

Comment 13

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/78089a268b01