1958981 - add context menu entrypoint for link preview

Status: VERIFIED FIXED

(Core :: Machine Learning: General, enhancement)

Description

[Ed Lee :Mardak]

in addition to keyboard shortcut bug 1943391, we'll want to show preview via context menu. bug 1951148 added a start event that supports multiple sources so this should report "context"

the context menu items can be conditionally shown if opened from a page's link but the hover+keyboard behavior isn't limited to links from the page, e.g., bookmark toolbar or sidebar. i would think we can limit the url to the one from the page but that will likely differ from the current overLink behavior

Comment 1

[Tim Xia]

Attachment: Bug 1958981 - add context menu entrypoint for link preview - r=Mardak

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73f21ab7f3fb
add context menu entrypoint for link preview - r=Mardak,fluent-reviewers,firefox-ai-ml-reviewers,bolsson

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/076607502262
Revert "Bug 1958981 - add context menu entrypoint for link preview - r=Mardak,fluent-reviewers,firefox-ai-ml-reviewers,bolsson" for causing mochitests failures in browser_contextmenu.js

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for causing mochitests failures in browser_contextmenu.js

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/076607502262f4ffb0b7beae7edc072ab58a5d11
Log link: https://treeherder.mozilla.org/logviewer?job_id=508106678&repo=autoland&lineNumber=2066

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b5bd772178d
add context menu entrypoint for link preview - r=Mardak,fluent-reviewers,firefox-ai-ml-reviewers,bolsson

Comment 7

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/8b5bd772178d

Comment 8

[Ciprian Georgiu, Desktop QA]

I've verified that the context menu contains the "Preview Link" option and is correctly working on Windows 11, macOS 14 and Ubuntu 24.04. Tested with Beta 140.b2.