1943547 - Prepare confvars.sh and configure.sh customization for migration out of autoconf

Status: RESOLVED FIXED

(Thunderbird :: Build Config, task)

Description

[[:sergesanspaille]]

mozilla-central is moving toward removing its dependency on autoconf. As part of the process, we're turning confvars.sh and configure.sh customization sites into simple key/value files, with potential substitution.

Thunderbirds customizations ites holds some legacy code which could be cleaned-up in order to prepare migration.

Comment 1

[[:sergesanspaille]]

Attachment: Bug 1943547 - Remove legacy configuration variables out of confvars.sh r=rjl!

MOZ_VERIFY_MAR_SIGNATURE can be set from mail/moz.configure
THUNDERBIRD_OFFICIAL_BRANDING is actually always set so no default needed

MOZ_BINARY_EXTENSIONS, MOZ_SEPARATE_MANIFEST_FOR_THEME_OVERRIDES and
MOZ_ENABLE_SIGNMAR are actually obsolete and never used.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d8c7e291f791
Remove legacy configuration variables out of confvars.sh r=dandarnell

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bb3e55203311
Follow up lint fix. rs=bustage-fix DONTBUILD

Comment 4

[Daniel Darnell [:dandarnell]]

Attachment: Bug 1943547 - Temporarily hard-code MOZ_OFFICIAL_BRANDING_DIRECTORY into confvars.sh. r=coreycb

Comment 5

[Daniel Darnell [:dandarnell]]

Comment on attachment 9471173 [details]
Bug 1943547 - Temporarily hard-code MOZ_OFFICIAL_BRANDING_DIRECTORY into confvars.sh. r=coreycb

[User impact if declined]

• MSIX cannot ship

[Is this code covered by automated tests?]

• No

[Has the fix been verified in Daily? (or Beta for an ESR uplift?)]

• This is a temporary beta-specific fix

[Needs manual test from QA?]

• No

[Risk to taking this patch]

• Low

Comment 6

[Corey Bryant]

Comment on attachment 9471173 [details]
Bug 1943547 - Temporarily hard-code MOZ_OFFICIAL_BRANDING_DIRECTORY into confvars.sh. r=coreycb

[Triage Comment]
Approved for beta

Comment 7

[Daniel Darnell [:dandarnell]]

Unfortunately, it looks like Firefox still has not moved forward with updating MSIX repackaging to use moz.configure, so I'm going to go ahead and move ahead with my own mozilla-central patch.