1945710 - Enhance the quick light/dark toggle for the dark reader mode

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, enhancement, P3)

Description

[Michel]

Just a few remarks about the new quick light/dark toggle for the dark reader mode
It only appears in dark mode, perhaps it can be made to appear only when viewing full html email messages, when it actually changes something.
The color used on the button should be Thunderbirds highlight color, not the system accent color, maybe even just black & white would be fine.
The tooltip should be "Toggle dark message mode", perhaps it can be made to alter between "Enable..." and "Disable...".

Comment 1

[Richard Marti (:Paenglab)]

I can look for the colours. The toggle works also for plain text and it makes sense to show it all the time.

Comment 2

[Alessandro Castellani [:aleca]]

Thanks for the request.

It only appears in dark mode, perhaps it can be made to appear only when viewing full html email messages, when it actually changes something.

The toggle also affects sometimes plaintext messages so it's better to show it all the times in dark mode.

The color used on the button should be Thunderbirds highlight color, not the system accent color, maybe even just black & white would be fine.

Thunderbird should follow the system's accent color. I guess you're using the built-in Dark Theme rather than having the OS in dark mode.
We need to update the built-in dark theme to have the same colors of when the OS is in dark mode.

The tooltip should be "Toggle dark message mode", perhaps it can be made to alter between "Enable..." and "Disable...".

Mhhh...yeah, I think this is a good suggestion.
I'll explore this improvement.

Comment 3

[Michel]

The toggle also affects sometimes plaintext messages so it's better to show it all the times in dark mode.

Can you send me such a message? It seems rather unlikely to me.
Plain text messages can not set colors and therefore always show the colors of the theme in use.
There are no html colors to be swapped, changed or disabled.
Don't be fooled by the looks of a message, it is very easy to make html look like plain text.

Thunderbird should follow the system's accent color. I guess you're using the built-in Dark Theme rather than having the OS in dark mode.
We need to update the built-in dark theme to have the same colors of when the OS is in dark mode.

I don't think so, following the system accent color is a feature of the system auto theme, the dark and light themes use a default accent color.
It is this button that needs to be fixed, not the dark and light themes.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: Bug 1945710: Enhance the .toggle-checkbox. r=#thunderbird-front-end-reviewers

Comment 5

[Geoff Lankow (:darktrojan) [PTO, back 8 Dec]]

This landed 12 hours ago. Pulsebot must be sleeping.
https://hg.mozilla.org/comm-central/rev/4a6ba9153e491ac24f33960584d26d3574f4243e