1945993 - Tab shrinks below tabMinWidth size when media indicator is active

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Zack Boehm]

Attachment: Tab shrinking below set minimum width when media is active

Steps to reproduce:

Set browser.tabs.tabMinWidth to a value greater than 100
Activate the tab's media controls by playing media or muting the tab

Actual results:

The width of the tab shrinks below browser.tabs.tabMinWidth

Expected results:

browser.tabs.tabMinWidth should be respected during media playback

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Tabbed Browser' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Zack Boehm]

Ah, important note: tabs must be overflowing/scrolling for this to occur.

Comment 3

[Alice0775 White]

Even if browser.tabs.tabMinWidth remains the default value, the tab size changes.
See screen cast: https://youtu.be/n7s2rFurfbk

And regardless of whether the TabStrip is overflowing or not.
See screen cast: https://youtu.be/E8RH03o0zoU

Comment 4

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6a036bf6bcc2d2b1c06cf5fef64e4fe1154c86c8&tochange=2821188eb89d208b750262e5681d9ed6f144097a

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

:kcochrane, since you are the author of the regressor, bug 1921060, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 6

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1945993 - Make sure browser.tabs.tabMinWidth pref is applied as expected to horizontal tabs

Comment 7

[Donal Meehan [:dmeehan]]

:dao pinging as triage owner, could this be triaged for severity?

Next week is the final week of beta for Fx136. I'm wondering if this needs a potential uplift or it can ride the train wherever it lands.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9bd46212a075
Make sure browser.tabs.tabMinWidth pref is applied as expected to horizontal tabs r=desktop-theme-reviewers,tabbrowser-reviewers,dao

Comment 9

[amarc]

https://hg.mozilla.org/mozilla-central/rev/9bd46212a075

Comment 10

[Dan]

Please please uplift into a dot release (something like 136.0.1 for example is what I mean) .

Comment 11

[Dan]

How many days will the QE team require for this rather major issue (for all us users who customize Firefox appearance as far as adjusting tab width to a custom value) to approve for uplift to a 136.0 dot release? ;((

Comment 12

[Dan]

Well?

Comment 13

[Donal Meehan [:dmeehan]]

(In reply to Dan from comment #12)

Well?

This has a regression which is pending investigation and fix.
This will ship with Fx137, scheduled to release on 2025-04-01

Comment 14

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

I was able to reproduce the issue on an affected Firefox Nightly 137.0a1 build from 2025-02-04 using macOS 13, while following the steps provided in Comment 0 and Comment 2.
Verified as fixed using Firefox 137.0b3 on Windows 11, macOS 13 and Ubuntu 22.04. The width of the tab respects the browser.tabs.tabMinWidth value.

Comment 15

[Dan]

So can sb. request an uplift to a 136 dot release now please? (This issue probably affects hundreds of users, everyone who customized that user pref)

Comment 17

[Dan]

(In reply to Donal Meehan [:dmeehan] from comment #13)

(In reply to Dan from comment #12)

Well?

This has a regression which is pending investigation and fix.
This will ship with Fx137, scheduled to release on 2025-04-01

Why was a rather quite minor Mac OS bug (bug 1947723), that was reported after this tab shrink bug, uplifted to the dot release (136.0.1) but this much more important one not? 🤔😭 Well, here my official request with reasoning included.

Dot Release [136.0.2] Uplift Approval Request

• User impact if declined/Reason for urgency: hundreds of users/Mozilla donators (or thousands? Is it listed on this database, can we see the user-count of that config edit there at least? https://probes.telemetry.mozilla.org/?search=Width, is it in there? Please check if that browser.tabs.tabMinWidth config change counter is tracked anywhere if able) who use Fx due to it's ability for tab customization and thus utilize the incredibly practical tab width cusomization are waiting for a fix for this since over a month now. Waiting ~3 more weeks is just very unfair imo, us/our Mozilla donators & users deserve quite a bit better, I hope you agree.
• Is this code covered by automated tests?: ? (=unknown to me)
• Has the fix been verified in Nightly?: Yes, even in Beta 137.0b3 already
• Needs manual test from QE?: ?
• If yes, steps to reproduce: see bug description
• List of other uplifts needed: none
• Risk to taking this patch: Low (afaik, or?)
• Why is the change risky/not risky? (and alternatives if risky): ?
• String changes made/needed: ?
• Is Android affected?: No

Comment 18

[Donal Meehan [:dmeehan]]

Respectfully, this has already been responded to in Comment 13
https://bugzilla.mozilla.org/page.cgi?id=etiquette.html