Closed Bug 1946011 Opened 1 year ago Closed 1 year ago

Use UTF-8 strings for server names and folder names

Categories

(MailNews Core :: General, task)

task

Tracking

(Not tracked)

RESOLVED FIXED
137 Branch

People

(Reporter: darktrojan, Assigned: darktrojan)

References

Details

Attachments

(2 files)

Our new database is going to use UTF-8. The current code uses 16-bit strings to store names in memory, but whether we use 8- or 16-bit there is a bit of a 50/50 call. If we switch it all over to UTF-8 now that will make the work of adapting the code for the new database much easier. It does mean converting to UTF-16 every time we want to deal with the file system (which will be less often once we have a new database) or L10n (much of which shouldn't be a back-end problem), but OTOH handling folder URIs won't involve character set conversion (they will hopefully go away with a new database).

Attachment #9463974 - Attachment description: WIP: Bug 1946011 - Use UTF-8 strings for server names and folder names. r=#thunderbird-back-end-reviewers → Bug 1946011 - Use UTF-8 strings for server names and folder names. r=#thunderbird-back-end-reviewers

This function returns NS_OK in all circumstances, and it modifies the string passed in, which is
not really what any of the callers want. Let's fix both things at once.

Depends on D236833.

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/e49801f1255a
Use UTF-8 strings for server names and folder names. r=mkmelin,BenC
https://hg.mozilla.org/comm-central/rev/401f9f5b6f43
Change and test how NS_MsgHashIfNecessary works. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch
See Also: → 1947954
Regressions: 1959848
Regressions: 1960372
Regressions: 1958781
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: