1946404 - Add manual sytem insets handling

Status: RESOLVED FIXED

(Firefox for Android :: General, enhancement)

Description

[Petru-Mugurel Lingurar [:petru]]

To support Android 15's edge to edge functionality - bug 1916695
And to improve layout animations when the software keyboard is being shown or hidden - bug 1911042
We should handle ourselves applying and reacting to system and ime insets.

This was initially done in bug 1911042 but later backed out in bug 1933488 after problems were reported in displaying websites.
After the patches from bug 1937785 I think the issues with empty - non-rendered space after opening the keyboard do not reproduce anymore so we should land back the patches from bug 1911042.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

To get more confidence in landing this work again I ask for support in testing the scenarios from bug 1933488 and bug 1933227 on Android 10+, including on the Oppo device from bug 1933488 comment 15 on the builds from this try (using probably the target.arm64-v8a.apk artifact).

Comment 2

[Delia Pop (Android QA)]

Attachment: debug_build.mp4

I've tested the scenarios mentioned in the tickets from the previous comment using the debug build provided, and all seems in good order: none of the previous issue could be reproduced and no other issues were observed at this point. Tested with OPPO A15s (Android 10), Samsung Galaxy Note 8 (Android 12) and Lenovo Yoga Tab 11 (Android 12).

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1946404 - Use manual handling of system insets r=#android-reviewers

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1946404 - Use manual handling of system insets r=#android-reviewers

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1946404 - Remove edge to edge opt out for API 35+ r=#android-reviewers

We are now handling edge to edge ourselves.

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1946404 - Use a ConstraintLayout parent to anchor snackbars r=#android-reviewers

This is a workaround for the issue from
https://github.com/material-components/material-components-android/issues/3446
which can be avoided if the parent of the snackbar does not provide MarginLayoutParams.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3355377fb4b1
Use manual handling of system insets r=android-reviewers,mcarare
https://hg.mozilla.org/integration/autoland/rev/ac46b0f1f7d3
Remove edge to edge opt out for API 35+ r=android-reviewers,mcarare
https://hg.mozilla.org/integration/autoland/rev/83ed17be8e13
Use a ConstraintLayout parent to anchor snackbars r=android-reviewers,mcarare,007

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3355377fb4b1
https://hg.mozilla.org/mozilla-central/rev/ac46b0f1f7d3
https://hg.mozilla.org/mozilla-central/rev/83ed17be8e13

Comment 9

[Petru-Mugurel Lingurar [:petru]]

@QA Please help validate that this

• fixes the issue from bug 1911042 (the bottom toolbars follow the show/hide keyboard animations and do not jump to the final position)
• does not cause issues with snackbar placements - like seen previously in bug 1932904
• does not cause issues in web rendering after the keyboard opens - like seen previously in bug 1933488

This should be verified on Android 10 devices, including a OPPO A15s with Android 10 device which previously shown issues.

Comment 10

[Petru-Mugurel Lingurar [:petru]]

Will ask to backout this as it enables bug 1934443 comment 11 to be reproducing.

Comment 11

[Serban Stanca [:SerbanS]]

Backed out as requested by plingurar for enabling rendering issues, pending more investigation.

• Backout link

Comment 12

[Petru-Mugurel Lingurar [:petru]]

Considering this as blocked by bug 1938303.

Comment 13

[Norisz Fay [:noriszfay]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/5e54a7b06c8b

Comment 14

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1946404 - Use manual handling of system insets r=#android-reviewers

Comment 15

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1946404 - Remove edge to edge opt out for API 35+ r=#android-reviewers

We are now handling edge to edge ourselves.

Comment 16

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1946404 - Use a ConstraintLayout parent to anchor snackbars r=#android-reviewers

This is a workaround for the issue from
https://github.com/material-components/material-components-android/issues/3446
which can be avoided if the parent of the snackbar does not provide MarginLayoutParams.

Comment 17

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1946404 - Have system insets handling APIs supporting only Android 13+ r=#android-reviewers

Using these APIs on lower versions of Android on devices from some
manufacturers was shown to lead to bugs in the application from the
inconsistencies of the insets framework of those devices.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76453fe8bc1a
Have system insets handling APIs supporting only Android 13+ r=android-reviewers,mcarare
https://hg.mozilla.org/integration/autoland/rev/50ed43521a03
Use manual handling of system insets r=android-reviewers,mcarare
https://hg.mozilla.org/integration/autoland/rev/682db1ec8722
Remove edge to edge opt out for API 35+ r=android-reviewers,mcarare
https://hg.mozilla.org/integration/autoland/rev/1772f74a856d
Use a ConstraintLayout parent to anchor snackbars r=android-reviewers,mcarare

Comment 19

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/76453fe8bc1a
https://hg.mozilla.org/mozilla-central/rev/50ed43521a03
https://hg.mozilla.org/mozilla-central/rev/682db1ec8722
https://hg.mozilla.org/mozilla-central/rev/1772f74a856d

Comment 20

[Petru-Mugurel Lingurar [:petru]]

@QA Please help validate that this

• fixes the issue from bug 1911042 (the bottom toolbars follow the show/hide keyboard animations and do not jump to the final position) on Android 13+.
• does not cause issues with snackbar placements - like seen previously in bug 1932904
• does not cause issues in web rendering after the keyboard opens - like seen previously in bug 1933488

This should be verified on devices with different versions of Android (below and after Android 13) and different form factors.

Comment 21

[Delia Pop (Android QA)]

Verified as fixed in latest Nightly 138.0a1 from 03/21. All 3 scenarios were tested with different pages (web searches, filling forms, using "find in page" on webpages and pdfs) and no issues were observed.
There are no black spaces above/under the toolbar/nav bar and all snackbars displayed throughout the application appear in the correct position.
Tested with the following devices: Google Pixel 8 Pro (Android 15), Nothing Phone (2a) 5G (Android 14), Motorola Moto G30 (Android 12), OPPO A15s (Android 10).

Comment 22

[Michel Le Bihan]

Those changes probably caused https://bugzilla.mozilla.org/show_bug.cgi?id=1955723