1947554 - No new mail notification on new IMAP messages anymore

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect, P1)

Description

[John Bieling]

New mail notifications are no longer shown. I tracked it down to
https://phabricator.services.mozilla.com/D234217

OK build:
m-c: 0da4e2f4d975fa56cabcc3efecf60f3faca30b29
c-c: 36522267f5c2c8da1f4335022d4a438a64213977

BAD build
m-c: 0da4e2f4d975fa56cabcc3efecf60f3faca30b29
c-c: 9ba85c3b79059081a384ca3a06841582d05323bc

Comment 1

[Magnus Melin [:mkmelin]]

IMAP I assume? Is it the same with pop3?

Comment 2

[John Bieling]

IMAP: no notification shown
POP: notification shown

Comment 3

[Magnus Melin [:mkmelin]]

I do actually see this on linux as well.
But it works for some cases (such as after startup), just not the when received through idle.

Comment 4

[John Bieling]

Yes, I think the onFolderIntPropertyChanged events for BiffState and NewMailReceived are not fired.

Comment 5

[Ben Campbell]

I can replicate this on Linux too - when new messages come in via IMAP, there's no notification.

However, if you set up a filter to unconditionally move all incoming messages to another folder (on the same IMAP account), the notifications do appear when new messages are delivered.

Comment 6

[Geoff Lankow (:darktrojan)]

I found it. CallFilterPlugins is returning early before setting aFiltersRun to false, so this call to SetBiffState is not made.

Checking on the folder lock didn't happen in this code path before. I guess it's okay, not really sure. But moving *aFiltersRun = false up fixes the bug.

Comment 7

[Magnus Melin [:mkmelin]]

Thanks Geoff! I can confirm that's the issue. That's what we get for using uninitialized out variables it seems :-/

Comment 8

[Magnus Melin [:mkmelin]]

Attachment: Bug 1947554 - Fix No new mail notification on new IMAP messages anymore. r=#thunderbird-reviewers,darktrojan

Make sure filtersRun out is false until we way otherwise.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/089f77113dc9
Fix No new mail notification on new IMAP messages anymore. r=john.bieling

Comment 10

[Magnus Melin [:mkmelin]]

Comment on attachment 9465644 [details]
Bug 1947554 - Fix No new mail notification on new IMAP messages anymore. r=#thunderbird-reviewers,darktrojan

[User impact if declined]

• No new mail notification from background checks

[Is this code covered by automated tests?]

• No

[Has the fix been verified in Daily? (or Beta for an ESR uplift?)]

• Yes

[Needs manual test from QA?]

• If wanted, send yourself an email to an imap account, and see that there is a notification about it.

[List of other uplifts needed]

[Risk to taking this patch]

• Options: Low
• Provide moving a variable initialization.

[String changes made/needed]

• none

Comment 11

[Corey Bryant]

Comment on attachment 9465644 [details]
Bug 1947554 - Fix No new mail notification on new IMAP messages anymore. r=#thunderbird-reviewers,darktrojan

[Triage Comment]
Approved for beta

Comment 12

[Corey Bryant]

Thunderbird 136.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/2bd0cc76f02e