1948263 - Add app menu item to show the Extensions Panel when the Extensions button is hidden

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P2)

Description

[Rob Wu [:robwu]]

From the PRD, https://docs.google.com/document/d/1PuYC1SCCD2iBU92LVSnQgZd5oVWWkqDAmRhHIz95ic4/edit

"Improve app menu item for add-ons"
Rename add-ons and themes menu item to just Extensions and change the behaviour to have it open the extensions panel. If the extensions button is hidden, we will show the button and pop out the panel.

The label add-ons and themes is inconsistent, as a theme is an add-on and it doesn’t mention extensions at all. Longer term, themes will be more closely aligned with the Appearance settings area in Firefox and less tied to extensions or about:addons
Improve app menu item for add-ons

On mobile, the menu item was renamed before in bug 1885561.

Strings to change:

• https://searchfox.org/mozilla-central/rev/43ed185f20ba4d3ef28c78b85102ea88fa63c947/browser/locales/en-US/browser/appmenu.ftl#34-35
• https://searchfox.org/mozilla-central/rev/43ed185f20ba4d3ef28c78b85102ea88fa63c947/browser/locales/en-US/browser/menubar.ftl#268-269

The menu items were renamed before in bug 1698931, from "Extensions and Themes" to "Add-ons and Themes".

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1948263 - Show "Moved to menu" notification after hiding

Comment 2

[Rob Wu [:robwu]]

Attachment: Bug 1948263 - Add Extensions appmenu item if needed

By default, this patch does not change any behavior.
Only when the Extensions Button is hidden, then this replaces the
current generic "Add-ons and Themes" option with the "Extensions"
menu, which opens the Extensions Panel.

Comment 3

[Rob Wu [:robwu]]

Attachment: Bug 1948263 - Change "Add-ons and Themes" to "Extensions and Themes"

This change is made for the following reasons:

• Similarity between new "Extensions" menu item, which shows up instead
  of "Extensions and Themes" when the Extensions Button is hidden.
• Consistency with about:preferences, which shows "Extensions & Themes"
  (this was introduced in bug 1483335 and was not touched when the menu
  labels were renamed in bug 1698931).
• Consistency with mobile (bug 1885561)

This effectively reverts the rename of bug 1698931.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a15c76809ad
Show "Moved to menu" notification after hiding r=willdurand,fluent-reviewers,bolsson
https://hg.mozilla.org/integration/autoland/rev/028962272326
Add Extensions appmenu item if needed r=willdurand,fluent-reviewers,bolsson,Gijs
https://hg.mozilla.org/integration/autoland/rev/4c29a6821719
Change "Add-ons and Themes" to "Extensions and Themes" r=willdurand,fluent-reviewers,bolsson

Comment 6

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/7a15c76809ad
https://hg.mozilla.org/mozilla-central/rev/028962272326
https://hg.mozilla.org/mozilla-central/rev/4c29a6821719