1948908 - Adapt more of the system addons tests to the new system addons builtin location

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P2)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

As followup to Bug 1938155 changes to introduce a new builtin location for system addons, we should be adapting more of the system addons tests (and in particulart the test_system_*.js AOM xpcshell tests).

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1948908 - Cover system builtin location in test_nodisable_hidden.js.

Depends on D235994

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1948908 - Cover system builtin location in test_system_allowed.js.

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1948908 - Cover system builtin location in test_system_delay_update.js.

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1948908 - Cover system builtin location in test_loadManifest_isPrivileged.js.

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1948908 - Cover system builtin location in test_system_reset.js (and related fixes on XPIProvider/XPIDatabase side).

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1948908 - Cover system builtin location in test_system_update_blank.js.

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1948908 - Cover system builtin location in test_system_repository.js.

Comment 8

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1948908 - Cover system builtin location in test_system_update_checkSizeHash.js.

Comment 9

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1948908 - Cover system builtin location in test_system_startuppref.js.

Comment 10

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1948908 - Tweak test_system_upgrades.js to expect locked system builtin location.

Comment 11

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1948908 - Tweak test_system_upgrades.js to explicit cover system addon precedence for the system builtin location.

Comment 12

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1948908 - Cover system builtin location in test_update.js.

Comment 13

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1948908 - Cover system builtin location in test_system_update_fail/newset/overlapping/upgrades/empty.js.

Comment 14

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: WIP: Bug 1948908 - Cover system builtin location in test_system_update_newset.js.

Comment 15

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: WIP: Bug 1948908 - Cover system builtin location in test_system_update_overlapping.js.

Comment 16

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: WIP: Bug 1948908 - Cover system builtin location in test_system_update_upgrades.js.

Comment 17

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: WIP: Bug 1948908 - Cover system builtin location in test_system_update_empty.js.

Comment 18

[Phabricator Automation]

Comment on attachment 9467241 [details]
Bug 1948908 - Cover system builtin location in test_system_reset.js (and related fixes on XPIProvider/XPIDatabase side).

Revision D238841 was moved to bug 1938155. Setting attachment 9467241 [details] to obsolete.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c5d293cea05
Cover system builtin location in test_nodisable_hidden.js. r=baku
https://hg.mozilla.org/integration/autoland/rev/84e2ce75706b
Cover system builtin location in test_system_allowed.js. r=baku,willdurand
https://hg.mozilla.org/integration/autoland/rev/a577a9c586c5
Cover system builtin location in test_system_delay_update.js. r=baku,willdurand
https://hg.mozilla.org/integration/autoland/rev/16289c1cea1b
Cover system builtin location in test_loadManifest_isPrivileged.js. r=baku
https://hg.mozilla.org/integration/autoland/rev/90cf6900cb54
Cover system builtin location in test_system_update_blank.js. r=willdurand,baku
https://hg.mozilla.org/integration/autoland/rev/6ba077560f50
Cover system builtin location in test_system_repository.js. r=baku,willdurand
https://hg.mozilla.org/integration/autoland/rev/6f5f5b622520
Cover system builtin location in test_system_update_checkSizeHash.js. r=baku,willdurand
https://hg.mozilla.org/integration/autoland/rev/2ed30a8b4868
Cover system builtin location in test_system_startuppref.js. r=baku,willdurand
https://hg.mozilla.org/integration/autoland/rev/de24f0174108
Tweak test_system_upgrades.js to explicit cover system addon precedence for the system builtin location. r=baku,willdurand
https://hg.mozilla.org/integration/autoland/rev/a6b5ae55e1a4
Cover system builtin location in test_update.js. r=willdurand,baku
https://hg.mozilla.org/integration/autoland/rev/abdb1877c2ed
Cover system builtin location in test_system_update_fail/newset/overlapping/upgrades/empty.js. r=baku,willdurand

Comment 20

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6c5d293cea05
https://hg.mozilla.org/mozilla-central/rev/84e2ce75706b
https://hg.mozilla.org/mozilla-central/rev/a577a9c586c5
https://hg.mozilla.org/mozilla-central/rev/16289c1cea1b
https://hg.mozilla.org/mozilla-central/rev/90cf6900cb54
https://hg.mozilla.org/mozilla-central/rev/6ba077560f50
https://hg.mozilla.org/mozilla-central/rev/6f5f5b622520
https://hg.mozilla.org/mozilla-central/rev/2ed30a8b4868
https://hg.mozilla.org/mozilla-central/rev/de24f0174108
https://hg.mozilla.org/mozilla-central/rev/a6b5ae55e1a4
https://hg.mozilla.org/mozilla-central/rev/abdb1877c2ed