1949847 - Remove app-system-defaults directory location once all system addons have been migrated into the omni jar

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P2)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

As a followup to migrating all system addons into the omni jar (and retired the Screenshots system addons), we will remove the unused app-system-defaults directory location.

Tests covering the app-system-defaults location are being adapted to also cover the new app-system-builtins location as part of Bug 1948908, the same set of tests will also need to be changes along with removing the app-system-defaults location.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1949847 - Remove deprecated app-system-defaults directory location r=baku,willdurand!

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

The attached patch includes a rebased and updated version of an exploratory patch I had prepared locally while going through all tests to be adapted to run on the new builtin location where we have migrated the addons previously installed in the app-system-defaults directory location (Bug 1948908), to keep track of the changes we would likely have to apply again to those tests as part of removing the deprecated app-system-defaults as part of this bugzilla issues.

There are other parts that will need to be cleaned up in addition to what the attached patch is currently covering (e.g. on the python script gen_built_in_addons.py).

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a9fa2fa6a241524ab9e377ed8147ccd516db653b

Comment 4

[Andrea Marchesini [:baku]]

Attachment: Bug 1949847 - Cleanup built_in_addons script to get rid of system addons, r?rpl

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

Push to try for the https://phabricator.services.mozilla.com/D243111 patch on its own:

• https://treeherder.mozilla.org/jobs?repo=try&revision=a9fa2fa6a241524ab9e377ed8147ccd516db653b

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

Last push to try with just D243111 didn't seem to caught any suspicious failure.

New push to try after rebase with both patches:

• webextension preset: https://treeherder.mozilla.org/#/jobs?repo=try&revision=111f1aebc1219627fc7236bd3d780c42dc39edef
• try auto: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3a02f0b43f37d7f875bec432b53f9060844c20fb

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

Hi John,
I'm adding this needinfo to let you know that we are planning to land soon this patch stack that I mentioned you over Matrix, and it is going to remove the system-defaults add-ons location. Would you mind to confirm if Thunderbird builds are using any system/built-in add-on or leveraging Firefox Desktop built-in add-ons like webcompat and formautofill and may need the kind of change that I mentioned in the comment on phabricator and file a bugzilla issue to track that followup in the Thunderbird bugzilla components?

Comment 8

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1949847 - Migrate test_addons_store.js unit test away from deprecated system-defaults location. r?baku,willdurand

Depends on D243111

Comment 9

[John Bieling (:TbSync)]

@Luca: I could not find a Thunderbird usage of the system-defaults add-on location. Corey, do you know of any system add-ons which we might ship with Thunderbird?

Comment 10

[Corey Bryant]

I don't know of any either and am finding no use of app-system-defaults in Thunderbird

Comment 11

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1949847 - Migrate TelemetryEnvironment tests away from deprecated system-defaults location. r=chutten!,willdurand!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0492d1d741a
Remove deprecated app-system-defaults directory location r=willdurand
https://hg.mozilla.org/integration/autoland/rev/ce72ab231796
Migrate test_addons_store.js unit test away from deprecated system-defaults location. r=willdurand,sync-reviewers,markh
https://hg.mozilla.org/integration/autoland/rev/433dea3efa5d
Migrate TelemetryEnvironment tests away from deprecated system-defaults location. r=chutten,willdurand
https://hg.mozilla.org/integration/autoland/rev/597f461ec791
Cleanup built_in_addons script to get rid of system addons, r=rpl

Comment 13

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/a0492d1d741a
https://hg.mozilla.org/mozilla-central/rev/ce72ab231796
https://hg.mozilla.org/mozilla-central/rev/433dea3efa5d
https://hg.mozilla.org/mozilla-central/rev/597f461ec791

Comment 14

[Kai Engert [:KaiE:]]

Hello Luca, FYI, we're experiencing a new failure in Thunderbird automated tests, which might potentially be related to these changes.
However, this isn't a Thunderbird specific test, rather, we're executing Firefox tests inside a Thunderbird build.
Do you have ideas what changes Thunderbird might require to ensure the tests keep working?
See bug 1961091. Thanks in advance for any hints you might be able to provide.

Comment 15

[Alessandro Castellani [:aleca]]

Gentle ping regarding comment 14

Comment 16

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Kai Engert [:KaiE:] from comment #14)

Hello Luca, FYI, we're experiencing a new failure in Thunderbird automated tests, which might potentially be related to these changes.
However, this isn't a Thunderbird specific test, rather, we're executing Firefox tests inside a Thunderbird build.
Do you have ideas what changes Thunderbird might require to ensure the tests keep working?
See bug 1961091. Thanks in advance for any hints you might be able to provide.

(In reply to Alessandro Castellani [:aleca] from comment #15)

Gentle ping regarding comment 14

Hi Kai and Alessandro, I have investigate the issue and pin-pointed the issue this morning. I have filed to track the change we need to fix it as Bug 1961356 and added it as a blocker for the bugzilla issue tracking the perma failure that Thunderbird builds are hitting (Bug 1961356).

I added some more details about the underlying issue and fix in Bug 1961356 comment 0 and verified localy that I was able to hit that same perma failure on a Thunderbird artifact build without the changes that are now attached to Bug 1961356 and that the test then passes as expected with that fix applied.

Comment 17

[Kai Engert [:KaiE:]]

Luca, thank you very much for your quick and complete help!