1949498 - Is the MEDIA_GMP_UPDATE_XML_FETCH_RESULT legacy telemetry histogram still needed

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, task)

Description

[Florian Quèze [:florian]]

A similar Glean metric was added in bug 1739664 almost 3 years ago, but slightly earlier the histogram was marked as "expire: never" in bug 1754642. Can we now remove the legacy telemetry histogram, or is it still used?

Comment 1

[Florian Quèze [:florian]]

Gijs, I think I intended to needinfo you, as you were the reviewer in both bug 1739664 and bug 1754642.

Comment 2

[:Gijs (he/him)]

(In reply to Florian Quèze [:florian] from comment #0)

A similar Glean metric was added in bug 1739664 almost 3 years ago, but slightly earlier the histogram was marked as "expire: never" in bug 1754642. Can we now remove the legacy telemetry histogram, or is it still used?

If the more elaborate glean telemetry covers this I expect we can remove the legacy one, but someone from the media team should really make these decisions - I only helped Bryce with review because the actual code/mechanics live in JS land. But I expect functionally we want to know if the mechanisms we use to download CDMs (and that, in practice, underpin most modern streaming video use of the browser), experience hiccups for whatever reason (and ideally there'd be alerting etc. etc.). Jim/Paul, unsure which of you to ping but please redirect/clear as appropriate.

Comment 3

[Paul Adenot (:padenot)]

302 Andrew

Comment 4

[Florian Quèze [:florian]]

Paul told me on matrix that it's fine to remove the histogram.

Comment 5

[Florian Quèze [:florian]]

Attachment: Bug 1949498 - Remove the MEDIA_GMP_UPDATE_XML_FETCH_RESULT legacy telemetry histogram (already migrated to Glean), r=padenot.

Comment 6

[Jim Mathies [:jimm]]

We're pulling from the data added in bug 1739664, so if that's sticking around we have no issue here.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b1e315c0cc0
Remove the MEDIA_GMP_UPDATE_XML_FETCH_RESULT legacy telemetry histogram (already migrated to Glean), r=padenot.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c54c0629061
Remove the MEDIA_GMP_UPDATE_XML_FETCH_RESULT legacy telemetry histogram (already migrated to Glean), r=padenot.

Comment 9

[Cosmin Sabou [:CosminS]]

Disregard https://hg.mozilla.org/integration/autoland/rev/735b84a612f686abea9a21b074f3d92789b4c0f1, it was a wrong revision copy.

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/7c54c0629061