1950710 - Migrate histograms to Glean - part 3 landing in Firefox 138

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task)

Description

[Florian Quèze [:florian]]

Third part of what started in bug 1935420 and continued in bug 1944631.

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1950710 - Migrate histograms to use Glean APIs in dom/power, r=chutten.

Comment 2

[Florian Quèze [:florian]]

Attachment: Bug 1950710 - Migrate histograms to use Glean APIs for QM_*_TIME_V0 in dom/quota, r=chutten.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8a478621690
Migrate histograms to use Glean APIs in dom/power, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/029980049c1e
Migrate histograms to use Glean APIs for QM_*_TIME_V0 in dom/quota, r=chutten.

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/d8a478621690
https://hg.mozilla.org/mozilla-central/rev/029980049c1e

Comment 5

[Florian Quèze [:florian]]

Attachment: Bug 1950710 - Migrate histograms to use Glean APIs in netwerk/cookie, r=chutten.

Comment 6

[Florian Quèze [:florian]]

Attachment: Bug 1950710 - Migrate histograms to use Glean APIs for IDLE_NOTIFY_IDLE_MS, r=chutten.

Comment 7

[Florian Quèze [:florian]]

Attachment: Bug 1950710 - remove the now unused Telemetry::AutoTimer class, r=chutten.

Comment 8

[Florian Quèze [:florian]]

Attachment: Bug 1950710 - remove the last traces of the expired FX_MIGRATION_*_IMPORT_MS and FX_MIGRATION_*_JANK_MS histograms, r=chutten.

The expired histogram definitions were already removed in https://phabricator.services.mozilla.com/D219401

Comment 9

[Florian Quèze [:florian]]

Attachment: Bug 1950710 - remove the now unused TelemetryStopwatch.*Keyed APIs, r=chutten.

Comment 10

[Florian Quèze [:florian]]

Attachment: Bug 1950710 - Migrate histograms to use Glean APIs for FX_TAB_SWITCH_*, r=chutten.

Comment 11

[Florian Quèze [:florian]]

Attachment: Bug 1950710 - remove the no longer used TelemetryStopwatch.timeElapsed API, r=chutten.

Comment 12

[Florian Quèze [:florian]]

Attachment: Bug 1950710 - Migrate histograms to use Glean APIs for FX_TAB_CLOSE_*, r=chutten.

Comment 13

[Florian Quèze [:florian]]

Attachment: Bug 1950710 - Migrate histograms to use Glean APIs for FX_PICTURE_IN_PICTURE_*, r=chutten.

Comment 14

[Florian Quèze [:florian]]

Attachment: Bug 1950710 - Migrate histograms to use Glean APIs for FULLSCREEN_CHANGE_MS, r=chutten.

Comment 15

[Florian Quèze [:florian]]

Attachment: Bug 1950710 - Migrate histograms to use Glean APIs in browser/base/content, r=chutten.

Comment 16

[Florian Quèze [:florian]]

Attachment: Bug 1950710 - Migrate histograms to use Glean APIs for PWMGR_*, r=chutten.

Comment 17

[Florian Quèze [:florian]]

Attachment: Bug 1950710 - remove the legacy telemetry histogram PWMGR_FORM_AUTOFILL_RESULT that has already been migrated to Glean in bug 1833398, r=dimi.

Comment 18

[Florian Quèze [:florian]]

Attachment: Bug 1950710 - Migrate histograms to use Glean APIs for UPDATE_LANGPACK_OVERTIME, r=chutten.

Comment 19

[Florian Quèze [:florian]]

Attachment: Bug 1950710 - remove the now unused TelemetryStopwatch.running API, r=chutten.

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9edd62877c98
Migrate histograms to use Glean APIs for IDLE_NOTIFY_IDLE_MS, r=chutten.

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/482b8c741722
remove the last traces of the expired FX_MIGRATION_*_IMPORT_MS and FX_MIGRATION_*_JANK_MS histograms, r=chutten,migration-reviewers,mconley.
https://hg.mozilla.org/integration/autoland/rev/9e57a5c12317
remove the now unused TelemetryStopwatch.*Keyed APIs, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/c5f6cd03c1d4
Migrate histograms to use Glean APIs for FX_TAB_SWITCH_*, r=chutten,tabbrowser-reviewers,mconley.
https://hg.mozilla.org/integration/autoland/rev/d2514bee519f
remove the no longer used TelemetryStopwatch.timeElapsed API, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/7a1f8fe65c63
Migrate histograms to use Glean APIs for FX_TAB_CLOSE_*, r=chutten,tabbrowser-reviewers,nsharpley.

Comment 22

[Serban Stanca [:SerbanS]]

Backed out for causing timeout related failures.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-TIMEOUT | automation.py | application timed out after 370 seconds with no output

Please also check these fxfn failures.

Comment 23

[Florian Quèze [:florian]]

Attachment: Bug 1950710 - Migrate histograms to use Glean APIs for MS_MESSAGE_REQUEST_TIME_MS, r=chutten.

Comment 24

[Florian Quèze [:florian]]

Attachment: Bug 1950710 - Migrate histograms to use Glean APIs for TEXT_RECOGNITION_*, r=chutten.

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/04aac27527e1
remove the last traces of the expired FX_MIGRATION_*_IMPORT_MS and FX_MIGRATION_*_JANK_MS histograms, r=chutten,migration-reviewers,mconley.

Comment 26

[Florian Quèze [:florian]]

Attachment: Bug 1950710 - Migrate histograms to use Glean APIs for FX_ABOUTHOME_CACHE_CONSTRUCTION, r=chutten.

Comment 27

[Florian Quèze [:florian]]

Attachment: Bug 1950710 - remove the TelemetryStopwatch API, r=chutten.

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1fff35a59468
Migrate histograms to use Glean APIs in netwerk/cookie, r=chutten,cookie-reviewers,valentin.
https://hg.mozilla.org/integration/autoland/rev/8f6a1665b96f
remove the now unused Telemetry::AutoTimer class, r=chutten.

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21debd5c2942
Migrate histograms to use Glean APIs for FX_TAB_SWITCH_*, r=chutten,tabbrowser-reviewers,mconley.
https://hg.mozilla.org/integration/autoland/rev/93a8cae3ce65
Migrate histograms to use Glean APIs for FX_TAB_CLOSE_*, r=chutten,tabbrowser-reviewers,nsharpley.

Comment 30

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69015eff5221
Migrate histograms to use Glean APIs for FX_PICTURE_IN_PICTURE_*, r=chutten,pip-reviewers,mconley.

Comment 31

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/670f7d4e6691
Migrate histograms to use Glean APIs in browser/base/content, r=chutten,reusable-components-reviewers,tgiles.
https://hg.mozilla.org/integration/autoland/rev/3a0eb039a76c
Migrate histograms to use Glean APIs for PWMGR_*, r=chutten,credential-management-reviewers,dimi.
https://hg.mozilla.org/integration/autoland/rev/b2e96f84c729
remove the legacy telemetry histogram PWMGR_FORM_AUTOFILL_RESULT that has already been migrated to Glean in bug 1833398, r=dimi.

Comment 32

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/04aac27527e1
https://hg.mozilla.org/mozilla-central/rev/1fff35a59468
https://hg.mozilla.org/mozilla-central/rev/8f6a1665b96f
https://hg.mozilla.org/mozilla-central/rev/21debd5c2942
https://hg.mozilla.org/mozilla-central/rev/93a8cae3ce65
https://hg.mozilla.org/mozilla-central/rev/69015eff5221
https://hg.mozilla.org/mozilla-central/rev/670f7d4e6691
https://hg.mozilla.org/mozilla-central/rev/3a0eb039a76c
https://hg.mozilla.org/mozilla-central/rev/b2e96f84c729

Comment 33

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9edd62877c98

Comment 34

[Florian Quèze [:florian]]

Attachment: Bug 1950710 - Migrate histograms to use Glean APIs in gfx/, r=chutten.

Comment 35

[Florian Quèze [:florian]]

Attachment: Bug 1950710 - remove the CONTENT_FRAME_TIME_REASON histogram that has already been migrated to Glean, r=chutten.

Comment 36

[Florian Quèze [:florian]]

Attachment: Bug 1950710 - Migrate histograms to use Glean APIs for WEBFONT_*, r=chutten.

Comment 37

[Florian Quèze [:florian]]

Attachment: Bug 1950710 - Migrate histograms to use Glean APIs for FX_CONTENT_CRASH_*, r=chutten.

Comment 38

[Florian Quèze [:florian]]

Attachment: Bug 1950710 - Migrate histograms to use Glean APIs for POPUP_NOTIFICATION_*, r=chutten.

Comment 39

[Florian Quèze [:florian]]

Attachment: Bug 1950710 - Migrate histograms to use Glean APIs for FIREFOX_VIEW_CUMULATIVE_SEARCHES, r=chutten.

Comment 40

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13d325bbcba4
Migrate histograms to use Glean APIs for FX_ABOUTHOME_CACHE_CONSTRUCTION, r=home-newtab-reviewers,mconley.

Comment 41

[Florian Quèze [:florian]]

(In reply to Serban Stanca [:SerbanS] from comment #22)

Backed out for causing timeout related failures.

It is likely the test failures were because https://phabricator.services.mozilla.com/D242166 depends on https://phabricator.services.mozilla.com/D241182 that hasn't landed yet. That would explain why it was green on my try runs that contained the entire stack.

Comment 42

[Florian Quèze [:florian]]

Attachment: Bug 1950710 - Migrate histograms to use Glean APIs in toolkit/components/crashes/CrashManager.in.sys.mjs, r=chutten.

Comment 43

[Florian Quèze [:florian]]

Attachment: Bug 1950710 - re-add static labels that were missed when migrating some histograms to Glean, r=chutten.

Comment 44

[Florian Quèze [:florian]]

Attachment: Bug 1950710 - Migrate histograms to use Glean APIs for ipc related histograms, r=chutten.

Comment 45

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/13d325bbcba4

Comment 46

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c4edd245f0c
Migrate histograms to use Glean APIs for UPDATE_LANGPACK_OVERTIME, r=application-update-reviewers,nalexander.

Comment 47

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/502d17566208
Migrate histograms to use Glean APIs for MS_MESSAGE_REQUEST_TIME_MS, r=chutten,omc-reviewers,mviar.

Comment 48

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70c951fc7448
Migrate histograms to use Glean APIs for FULLSCREEN_CHANGE_MS, r=chutten,pip-reviewers,mconley.

Comment 49

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0152d1a07cb
Migrate histograms to use Glean APIs for TEXT_RECOGNITION_*, r=chutten.

Comment 50

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6e45d6b0e7c
re-add static labels that were missed when migrating some histograms to Glean, r=chutten,necko-reviewers,anti-tracking-reviewers,valentin,emz.

Comment 51

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29b99e47ab8a
Migrate histograms to use Glean APIs for FX_CONTENT_CRASH_*, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/e9179bf003ae
Migrate histograms to use Glean APIs for POPUP_NOTIFICATION_*, r=chutten.

Comment 52

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8c4edd245f0c

Comment 53

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c9f05b7de06
remove the now unused TelemetryStopwatch.*Keyed APIs, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/e3133b14dc16
remove the no longer used TelemetryStopwatch.timeElapsed API, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/c26dab8d0bf8
remove the now unused TelemetryStopwatch.running API, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/a2f1101c02b7
remove the TelemetryStopwatch API, r=chutten,devtools-reviewers,home-newtab-reviewers,frontend-codestyle-reviewers,mconley,nchevobbe.

Comment 54

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/502d17566208
https://hg.mozilla.org/mozilla-central/rev/70c951fc7448
https://hg.mozilla.org/mozilla-central/rev/b0152d1a07cb
https://hg.mozilla.org/mozilla-central/rev/d6e45d6b0e7c
https://hg.mozilla.org/mozilla-central/rev/29b99e47ab8a
https://hg.mozilla.org/mozilla-central/rev/e9179bf003ae

Comment 55

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b79ffcd0a913
Migrate histograms to use Glean APIs for FIREFOX_VIEW_CUMULATIVE_SEARCHES, r=chutten,fxview-reviewers,jsudiaman.

Comment 56

[Phabricator Automation]

Comment on attachment 9474078 [details]
Bug 1950710 - Migrate histograms to use Glean APIs in gfx/, r=chutten.

Revision D242765 was moved to bug 1956726. Setting attachment 9474078 [details] to obsolete.

Comment 57

[Phabricator Automation]

Comment on attachment 9474079 [details]
Bug 1950710 - remove the CONTENT_FRAME_TIME_REASON histogram that has already been migrated to Glean, r=chutten.

Revision D242766 was moved to bug 1956726. Setting attachment 9474079 [details] to obsolete.

Comment 58

[Phabricator Automation]

Comment on attachment 9474080 [details]
Bug 1950710 - Migrate histograms to use Glean APIs for WEBFONT_*, r=chutten.

Revision D242767 was moved to bug 1956726. Setting attachment 9474080 [details] to obsolete.

Comment 59

[Phabricator Automation]

Comment on attachment 9474311 [details]
Bug 1950710 - Migrate histograms to use Glean APIs in toolkit/components/crashes/CrashManager.in.sys.mjs, r=chutten.

Revision D242911 was moved to bug 1956726. Setting attachment 9474311 [details] to obsolete.

Comment 60

[Phabricator Automation]

Comment on attachment 9474320 [details]
Bug 1950710 - Migrate histograms to use Glean APIs for ipc related histograms, r=chutten.

Revision D242916 was moved to bug 1956726. Setting attachment 9474320 [details] to obsolete.

Comment 61

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/5c9f05b7de06
https://hg.mozilla.org/mozilla-central/rev/e3133b14dc16
https://hg.mozilla.org/mozilla-central/rev/c26dab8d0bf8
https://hg.mozilla.org/mozilla-central/rev/a2f1101c02b7
https://hg.mozilla.org/mozilla-central/rev/b79ffcd0a913