Intermittent comm/mail/test/browser/folder-display/browser_savedsearchReloadAfterCompact.js | Uncaught exception in test bound test_setup_virtual_folder_and_compact which
Categories
(Thunderbird :: Folder and Message Lists, defect, P5)
Tracking
(thunderbird_esr128 unaffected)
| Tracking | Status | |
|---|---|---|
| thunderbird_esr128 | --- | unaffected |
People
(Reporter: intermittent-bug-filer, Unassigned)
References
(Regression)
Details
(Keywords: intermittent-failure, intermittent-testcase, regression, Whiteboard: [fixed by bug 1959858])
Attachments
(2 files)
Filed by: mkmelin [at] iki.fi
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=498006487&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/P5NfKcJVS6-5zE5p59bePg/runs/0/artifacts/public/logs/live_backing.log
| Comment hidden (Intermittent Failures Robot) |
| Comment hidden (Intermittent Failures Robot) |
Updated•9 months ago
|
Comment 3•9 months ago
|
||
Updated•9 months ago
|
Updated•9 months ago
|
Pushed by martin@humanoids.be:
https://hg.mozilla.org/comm-central/rev/ebf506b030ac
Fix intermittent comm/mail/test/browser/folder-display/browser_savedsearchReloadAfterCompact.js. r=tobyp
Comment 5•9 months ago
|
||
Didn't help :(
Apparently we get 0x80550005 which is NS_MSG_ERROR_FOLDER_SUMMARY_OUT_OF_DATE
Updated•9 months ago
|
Updated•9 months ago
|
Comment 6•9 months ago
|
||
Probably it isn't the test that's broken, see for example bug 1952311…
Comment 7•9 months ago
|
||
Since this didn't happen for a long time until 2025-03-07, maybe there is a connection to https://phabricator.services.mozilla.com/D238551.
Comment 8•9 months ago
|
||
Yep, that definitely seems like the likely culprit.
For reliability reasons the compaction now produces a new database file, which is installed atomically(ish) upon completion.
This means the database object is destroyed and recreated, which means things using that old DB need to switch to the new DB...
There is folder.notifyCompactCompleted() which tells a folder when the compaction happens. We use that to update the standard message view. That notification might also be useful to update whatever is holding onto the old database in this case?
https://searchfox.org/comm-central/search?q=notifyCompact&path=&case=false®exp=false
Comment 9•9 months ago
•
|
||
Since this is an intermittent and relatively rare error, it may simply be caused by a change in timing. I replaced the custom URL listener in the test with a PromiseTestUtils.PromiseUrlListener (like here). While I am not sure this really fixes the failure, it at least speeds up the test considerably. Try run.
By the way, the test itself seems a bit wonky: Saved search do not reload after a compaction happened, only the affected real folders do. The original reason for the test, message selection maintained by the back-end that might break the view, isn't a thing anymore (see bug 536676).
Comment 10•9 months ago
|
||
Updated•9 months ago
|
Comment 11•9 months ago
|
||
Pushed by toby@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/34ac3805467a
Try to fix intermittent comm/mail/test/browser/folder-display/browser_savedsearchReloadAfterCompact.js. r=mkmelin
Comment 12•9 months ago
|
||
New failure: https://treeherder.mozilla.org/jobs?repo=comm-central&selectedTaskRun=Xe1BQgDoRQGmfpyPOES2bw.0
Updated•9 months ago
|
Comment 13•9 months ago
|
||
Most likely the same root cause as bug 1952503:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?startday=2025-02-20&endday=2025-03-22&tree=comm-central&failurehash=all&bug=1952463
https://treeherder.mozilla.org/intermittent-failures/bugdetails?startday=2025-02-20&endday=2025-03-22&tree=comm-central&failurehash=all&bug=1952503
Error 0x8052000E (2152857614) in both tests, that's NS_ERROR_FILE_IS_LOCKED.
| Comment hidden (Intermittent Failures Robot) |
| Comment hidden (Intermittent Failures Robot) |
| Comment hidden (Intermittent Failures Robot) |
| Comment hidden (Intermittent Failures Robot) |
| Comment hidden (Intermittent Failures Robot) |
| Comment hidden (Intermittent Failures Robot) |
| Comment hidden (Intermittent Failures Robot) |
| Comment hidden (Intermittent Failures Robot) |
| Comment hidden (Intermittent Failures Robot) |
| Comment hidden (Intermittent Failures Robot) |
| Comment hidden (Intermittent Failures Robot) |
| Comment hidden (Intermittent Failures Robot) |
| Comment hidden (Intermittent Failures Robot) |
Comment 27•5 months ago
|
||
While bug 1952311 might have had some impact on this, this may very well now be fixed by bug 1959858.
Updated•5 months ago
|
Description
•