1952564 - New update checked "Cookies and site data" automatically for some users

Status: VERIFIED FIXED

(Toolkit :: Data Sanitization, defect, P1)

Description

[dtsa583s0]

Steps to reproduce:

Some users are reporting that Firefox 136 checked the option to clear "Cookies and site data" automatically for them. This is likely a regression caused by Bug 1888466.

I was not personally affected by this, since I had already manually checked this option. Please reach out to those users if you need more info.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:hsohaney, since you are the author of the regressor, bug 1888466, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Manuel Bucher [:manuel]]

I'm able to reproduce upgrading one of my Nightlies upgrading from Fx132 to Fx138.

Before

• [x] History (Clears site and download history, saved form info, and searches)
• [ ] Cookies and site data (May sign you out of sites or empty shopping carts)
• [ ] Temporary cached files and pages (Clears items that help sites load faster)
• [ ] Site settings (Resets your permissions and site preferences to original settings)

After:

• [x] Browsing & Download History
• [x] Cookies & site data
• [x] Temporary cached files and pages
• [x] Saved form info
• [ ] Site settings

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1888466

Comment 4

[Manuel Bucher [:manuel]]

Thanks for reporting!

I'll triage as:

• P1 as in "Fix in the current release cycle". Not sure what potential solutions could look like
• S2 as in Major functionality impaired. due to users being logged out unexpectedly

Will start investigating further. Feel free to downgrade if you disagree or if later information turns out this isn't as severe/important as thought. Due to workaround one could argue it is S3: "Blocks non-critical functionality or a work around exists".

Taking a look now.

Comment 5

[Manuel Bucher [:manuel]]

Attachment: Bug 1952564 - Fix "Cookies and site data" being set for users when migrating from clear-site-data dialog v2 to v3 (unmerge history and formdata) r=emz

Comment 6

[Manuel Bucher [:manuel]]

Bumping severity due cause of data loss for users that have clear data on shutdown activated. This is a potential dot release driver. Most noteable cookies and therefore logins. And less noticable cache and siteSettings. (not entirely sure if this is a correct assessment. please downgrade again to S2 if that is a better reflection of situation due to only a subset of users being affected and workaround existing).

Comment 7

[Manuel Bucher [:manuel]]

S2 fits better. Reflecting here in Bug.

Comment 8

[Emma Zühlcke [:emz]]

We've determined that this is not a dot release driver but we would ride along another dot release if it happens. It only affects a subset of users who have clear on shutdown enabled and the fix would only help users who have not updated to 136 yet.
Around 6% of all users have the feature enabled. Out of those 6% only those users are affected who have non default categories (selected or unselected), including the cookies and storage category.

Comment 9

[Manuel Bucher [:manuel]]

Attachment: Bug 1952564 - Fix "Cookies and site data" being set for users when migrating from clear-site-data dialog v2 to v3 (unmerge history and formdata) r=emz

Original Revision: https://phabricator.services.mozilla.com/D241037

Comment 10

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Users not updated to Fx136 yet might lose login data after update when having clear data on shutdown activated, but not clear cookies
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Set the prefs in Fx135 like in https://bugzilla.mozilla.org/show_bug.cgi?id=1952564#c2, then update to Fx136. Observe the additional checkboxes. Also possible to replicate by fiddeling with about:config preferences.
• Risk associated with taking this patch: low
• Explanation of risk level: fairly simple patch and testing coverage exists. Some paths already additionally manually verified. But additionally should go through QE.
• String changes made/needed: no
• Is Android affected?: no

Comment 11

[Manuel Bucher [:manuel]]

Attachment: Bug 1952564 - Fix "Cookies and site data" being set for users when migrating from clear-site-data dialog v2 to v3 (unmerge history and formdata) r=emz

Original Revision: https://phabricator.services.mozilla.com/D241037

Comment 12

[Phabricator Automation]

release Uplift Approval Request

• User impact if declined: Users not updated to Fx136 yet might lose login data after update when having clear data on shutdown activated, but not clear cookies
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Set the prefs in Fx135 like in https://bugzilla.mozilla.org/show_bug.cgi?id=1952564#c2, then update to Fx136. Observe the additional checkboxes. Also possible to replicate by fiddeling with about:config preferences.
• Risk associated with taking this patch: low
• Explanation of risk level: fairly simple patch and testing coverage exists. Some paths already additionally manually verified. But additionally should go through QE
• String changes made/needed: no
• Is Android affected?: no

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c0dde7af6e9
Fix "Cookies and site data" being set for users when migrating from clear-site-data dialog v2 to v3 (unmerge history and formdata) r=emz

Comment 14

[agoloman]

Backed out for causing browser_sanitizeDialog_v2.js.

• Backout link
• Push with failures
• Failure Log

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d785982f65b
Fix "Cookies and site data" being set for users when migrating from clear-site-data dialog v2 to v3 (unmerge history and formdata) r=emz

Comment 16

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/6d785982f65b

Comment 17

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/b6b50471b154

Comment 18

[Bogdan Maris, Desktop Test Engineering]

Reproduced the issue described in comments 2 and comment 10 using an update from Fx135 RC to Fx136 RC (affected). Verified that when updating from an old Nightly build 135.0a1 to latest Nightly 138.0a1 (fixed) only 2 options remain checked.

Before

[x] History
[ ] Cookies and site data
[ ] Temporary cached files and pages
[ ] Site settings
After:

[x] Browsing & Download History
[ ] Cookies & site data
[ ] Temporary cached files and pages
[x] Saved form info
[ ] Site settings

Is Saved from info supposed to be checked as well? If yes then I'll call this verified fixed on 138.0a1 and wait for beta 137.0b6 build to be out so I can verify that as well.

Comment 19

[Manuel Bucher [:manuel]]

Yes, "Saved form info" is supposed to be checked after the update due to the previous "History" item also including form data clearing.

Comment 20

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/df765b152acf

Comment 21

[Bogdan Maris, Desktop Test Engineering]

(In reply to Manuel Bucher [:manuel] from comment #19)

Yes, "Saved form info" is supposed to be checked after the update due to the previous "History" item also including form data clearing.

Thanks! Marking as verified fixed on 138 and on Firefox 137 as well since I also tested right now across platforms (Windows 11, macOS 13.7 and Ubuntu 22.04) and looks fixed as well.
Leaving this as rezolved for now, waiting to also test in 136 Release.

Comment 22

[Bogdan Maris, Desktop Test Engineering]

Also verified that this is fixed after updating from 135.0.1 to 136.0.2 across platforms (Windows 11, macOS 13.7 and Ubuntu 22.04).