1955924 - 3-Pane breaks (message list and message pane are stuck) when incoming message notification is clicked while having a Quick Filter on

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect, P2)

Description

[quadronom]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:136.0) Gecko/20100101 Firefox/136.0

Steps to reproduce:

I'm on 137.0b2 right now, on macOS 15.3.2, using 3-pane view exclusively.
Assume the following:
Thunderbird's open, a quick filter is applied.
Then a new message arrives and I get the macOS notification and click on it.

Actual results:

Thunderbird is now broken. The view of the two panes (message list and message content) will not change anymore, they are frozen.
Even if I disable the quick filter alltogether the panes do not update anymore. I can basically click anywhere; folder list, whatever, does not matter, it will not change.
TB has to be killed so the views are restored.

Expected results:

Clicking on the notification of macOS should give me the message and TB should stay responsive.
(= disable quick filters, etc. Whatever is needed).

Comment 1

[Corey Bryant]

Vlad/Ramona, can you recreate this?

Comment 2

[Ramona Gavrilescu]

Hello!

I have tried and was able to reproduce this issue,
I have tried on macOS 14.7.4 on the following version: 137.0b2(20250318122546)

TB was opened in 3-pane view, a quick filter (tags) was applied on the inbox of an account, when a new message was received and I clicked on the notification, TB became unresponsive, the Inbox list was not updated, disabling Quick filters did not update the Inbox list, I tried to click on any other folder or another account but they didn’t opened.
In the Error console the following errors were displayed:

NS_ERROR_UNEXPECTED: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIMsgDBView.hdrForFirstSelectedMessage] 3 about3Pane.js:6093     selectMessage chrome://messenger/content/about3Pane.js:6093     MsgDisplayMessageInFolderTab chrome://messenger/content/mailWindowOverlay.js:1247     displayMessageInFolderTab resource:///modules/MailUtils.sys.mjs:425     observe resource:///modules/MailNotificationManager.sys.mjs:91

Uncaught : Component returned failure code: 0x80550018 [nsIMsgDBView.getURIForViewIndex]     saveSelection chrome://messenger/content/about3Pane.js:5104     _onSelect chrome://messenger/content/about3Pane.js:2652     handleEvent chrome://messenger/content/about3Pane.js:1690     updateRowClasses chrome://messenger/content/tree-listbox-mixin.mjs:726     updateSelection chrome://messenger/content/tree-listbox-mixin.mjs:599     _onClick chrome://messenger/content/tree-listbox-mixin.mjs:189     handleEvent chrome://messenger/content/tree-listbox-mixin.mjs:156

An error occurred updating the cmd_delete command: [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIMsgDBView.viewIndexForFirstSelectedMsg]" nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)" location: "JS frame :: chrome://messenger/content/mailCommon.js :: canMove :: line 519" data: no] globalOverlay.js:81:13     goUpdateCommand chrome://messenger/content/globalOverlay.js:81     goUpdateGlobalEditMenuItems chrome://communicator/content/utilityOverlay.js:24     <anonymous>

NS_ERROR_CONTENT_BLOCKED: Component returned failure code: 0x805e0006 (NS_ERROR_CONTENT_BLOCKED) [nsIChannel.asyncOpen]     load resource:///modules/FaviconLoader.sys.mjs:175     load resource:///modules/FaviconLoader.sys.mjs:572     loadIcons resource:///modules/FaviconLoader.sys.mjs:651     onPageShow resource:///modules/FaviconLoader.sys.mjs:685     onPageShow resource:///actors/LinkHandlerChild.sys.mjs:66     handleEvent resource:///actors/LinkHandlerChild.sys.mjs:166 FaviconLoader.sys.mjs:586:19     load resource:///modules/FaviconLoader.sys.mjs:586

I have noticed that this behaviours happens when Quick Filter is applied (I tried with tags, unread, starred, attachments)
If Quick filter is not applied clicking on the notification TB works as expected.

I have tried on TB 128.8.1esr(20250317192722) and the behaviour is a bit different, clicking on the notification of the new message received does not open the email, but TB does not become unresponsive, Quick filter can be disabled, and the inbox list gets updated, opening other folders, or opening another account’s inbox/folders works as expected.

The following error is displayed in the Error console:

ncaught : Component returned failure code: 0x80550018 [nsIMsgDBView.getFlagsAt]     _onSelect chrome://messenger/content/about3Pane.js:4580     handleEvent chrome://messenger/content/about3Pane.js:4404     onSelectionChanged chrome://messenger/content/tree-view.mjs:1699     _selectSingle chrome://messenger/content/tree-view.mjs:1502     set selectedIndex chrome://messenger/content/tree-view.mjs:1577     selectMessage chrome://messenger/content/about3Pane.js:6260     MsgDisplayMessageInFolderTab chrome://messenger/content/mailWindowOverlay.js:1232     displayMessageInFolderTab resource:///modules/MailUtils.sys.mjs:422     observe resource:///modules/MailNotificationManager.sys.mjs:93 about3Pane.js:4580     _onSelect chrome://messenger/content/about3Pane.js:4580     handleEvent chrome://messenger/content/about3Pane.js:4404     onSelectionChanged chrome://messenger/content/tree-view.mjs:1699     _selectSingle chrome://messenger/content/tree-view.mjs:1502     set selectedIndex chrome://messenger/content/tree-view.mjs:1577     selectMessage chrome://messenger/content/about3Pane.js:6260     MsgDisplayMessageInFolderTab chrome://messenger/content/mailWindowOverlay.js:1232     displayMessageInFolderTab resource:///modules/MailUtils.sys.mjs:422     observe resource:///modules/MailNotificationManager.sys.mjs:93

Comment 3

[Wayne Mery (:wsmwk)]

Can anyone else reproduce, and find the regression range using https://mozilla.github.io/mozregression/quickstart.html ?

Does it also happen on Windows or Linux?

Comment 4

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1955924 - Fix selectMessage() for quick filtered views. r=#thunderbird-reviewers

Comment 5

[Hartmut Welpmann [:welpy-cw]]

I'm not sure this ever worked correctly, see bug 783040. The different behavior between ESR 128 and 137 may be related to the changes in bug 1924977, but I haven't verified this since the real issue is with about3pane.selectMessage(msgHdr).

Comment 6

[Hartmut Welpmann [:welpy-cw]]

Complete Try

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/64d03ac16dc6
Fix selectMessage() for quick filtered views. r=mkmelin