1938333 - Release geckodriver 0.37.0

Status: RESOLVED FIXED

(Testing :: geckodriver, task, P2)

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Putting on triage so that we can decide if we want to release a new version of geckodriver in M19. Could be a P3.

Comment 2

[Euclid Ye]

Can we also Release a new version of webdriver crate?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I'll try to do it all at once if that is not a pressing issue for you.

For geckodriver I would like to see at least bug 1957746 fixed before the release. Others we can probably move to 0.38.0.

Comment 4

[Euclid Ye]

Not pressing at all. Thanks!

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I'm going to move some of the dependencies over to the 0.38.0 release of geckodriver which will be tracked on bug 2031246.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Changes since commit cb05d0bd5c00 for all the crates:

mozdevice

➜ ['git', 'log', '--reverse', 'cb05d0bd5c00..HEAD', '--pretty=%s', 'testing/mozbase/rust/mozdevice']
Bug 1981210 - [rust-mozdevice] Use "-S" argument for "am start" to force stop an already running application r=whimboo,webdriver-reviewers
Bug 1955044 - Update Geckodriver to Rust 2024, r=whimboo,geckodriver-reviewers
Bug 1955044 - Fix new clippy warnings r=whimboo,geckodriver-reviewers
Bug 1839953 - [geckodriver] Detect when Firefox on Android exits during startup. r=geckodriver-reviewers,jgraham

mozprofile

➜ ['git', 'log', '--reverse', 'cb05d0bd5c00..HEAD', '--pretty=%s', 'testing/mozbase/rust/mozprofile']
Bug 1988570 - Fix 'hiding a lifetime that's elided elsewhere is confusing' errors in mozbase, r=webdriver-reviewers,whimboo
Bug 1955044 - Update Geckodriver to Rust 2024, r=whimboo,geckodriver-reviewers
Bug 1955044 - Fix new clippy warnings r=whimboo,geckodriver-reviewers

mozversion

➜ ['git', 'log', '--reverse', 'cb05d0bd5c00..HEAD', '--pretty=%s', 'testing/mozbase/rust/mozversion']
Bug 1955044 - Update Geckodriver to Rust 2024, r=whimboo,geckodriver-reviewers

mozrunner

➜ ['git', 'log', '--reverse', 'cb05d0bd5c00..HEAD', '--pretty=%s', 'testing/mozbase/rust/mozrunner']
Bug 1954021 - [mozrunner-rust] Use direct firefox binary for Snap r=whimboo,webdriver-reviewers
Bug 1617369 - Reformat recent rust changes with rustfmt r=emilio,webdriver-reviewers,whimboo
Bug 1975414 - Upgrade plist crate to 1.7.2 r=supply-chain-reviewers,webdriver-reviewers,whimboo
Bug 1955044 - Update Geckodriver to Rust 2024, r=whimboo,geckodriver-reviewers
Bug 1955044 - Mark usage of env::set_var and env::use_var as unsafe r=whimboo,geckodriver-reviewers
Bug 1955044 - Fix new clippy warnings r=whimboo,geckodriver-reviewers
Bug 1839953 - [geckodriver] Detect when Firefox on Android exits during startup. r=geckodriver-reviewers,jgraham

webdriver

➜ ['git', 'log', '--reverse', 'cb05d0bd5c00..HEAD', '--pretty=%s', 'testing/webdriver']
Bug 1894795 - build(rust): upgrade in-tree base64 deps. 0.21.3 → 0.22.1 in-tree r=webdriver-reviewers,necko-reviewers,whimboo,kershaw
Bug 1955903 - [rust-webdriver] Make entries in NewSessionParameters public. r=webdriver-reviewers,jgraham
Bug 1955903 - [rust-webdriver] Release version 0.52.1. r=webdriver-reviewers,jgraham
Bug 1952944 - [geckodriver] Camel-case arguments for Web Authentication commands. r=webdriver-reviewers,Sasha
Bug 1955903 - [webdriver-rust] Release version 0.53.0. r=webdriver-reviewers,jgraham
Bug 1960300 - Part 5. Vendor ICU4X 2.0. r=supply-chain-reviewers,platform-i18n-reviewers,webdriver-reviewers,sylvestre,dminor
Bug 1972670 - [remote] Remove FTP proxy support from WebDriver capabilities. r=webdriver-reviewers,Sasha
Bug 1969865 - Add tests for Global Privacy Control signal - r=jgraham,manuel
Bug 1855045 - [remote] Add basic support for file unhandledPromptBehavior in BiDi and geckodriver r=geckodriver-reviewers,Sasha
Bug 2000448 - [wdspec] Add wdspec tests for global_privacy_control - r=whimboo,geckodriver-reviewers,jgraham
Bug 2008345 - [geckodriver] Allow "null" for "implicit" and "pageLoad" timeouts. r=geckodriver-reviewers,jdescottes,jgraham
Bug 1955044 - Update Geckodriver to Rust 2024, r=whimboo,geckodriver-reviewers
Bug 1955044 - Fix new clippy warnings r=whimboo,geckodriver-reviewers
Bug 2023419 - Remove Emacs/Vim modelines from testing/ r=emilio,perftest-reviewers,jgraham,geckodriver-reviewers,sparky
Bug 1957746 - [geckodriver] Properly implement commands from the external WebAuthn specification. r=geckodriver-reviewers,jdescottes,jgraham
Bug 1430064 - [geckodriver] Quit Firefox when geckodriver is terminated. r=geckodriver-reviewers,jgraham,supply-chain-reviewers
Bug 2033393 - Vendor upgraded http, hyper, warp crates and their dependencies. r=supply-chain-reviewers,webrtc-reviewers,geckodriver-reviewers,jdescottes,jgraham,bwc,valentin,afranchuk,gsvelto,gw,padenot
Bug 2033393 - Vendor upgraded http, hyper, warp crates and their dependencies. r=supply-chain-reviewers,webrtc-reviewers,geckodriver-reviewers,jdescottes,jgraham,bwc,valentin,afranchuk,gsvelto,gw,padenot
Bug 2033393 - Adapt consumers to http 1.x, hyper 1.x, and windows-sys HANDLE type changes. r=necko-reviewers,geckodriver-reviewers,gsvelto,smaug,jgraham,gw,kershaw

marionette

➜ ['git', 'log', '--reverse', 'cb05d0bd5c00..HEAD', '--pretty=%s', 'testing/geckodriver/marionette']
Bug 1952944 - [geckodriver] Camel-case arguments for Web Authentication commands. r=webdriver-reviewers,Sasha
Bug 1969865 - Add tests for Global Privacy Control signal - r=jgraham,manuel
Bug 2000448 - [wdspec] Add wdspec tests for global_privacy_control - r=whimboo,geckodriver-reviewers,jgraham
Bug 2008345 - [geckodriver] Allow "null" for "implicit" and "pageLoad" timeouts. r=geckodriver-reviewers,jdescottes,jgraham
Bug 1955044 - Update Geckodriver to Rust 2024, r=whimboo,geckodriver-reviewers
Bug 2021832 - Remove special cases when converting types to marionette r=geckodriver-reviewers,whimboo
Bug 1957746 - [geckodriver] Properly implement commands from the external WebAuthn specification. r=geckodriver-reviewers,jdescottes,jgraham

geckodriver

➜ ['git', 'log', '--reverse', 'cb05d0bd5c00..HEAD', '--pretty=%s', 'testing/geckodriver/src']
Bug 1617369 - Reformat recent rust changes with rustfmt r=emilio,webdriver-reviewers,whimboo
Bug 1882096 - [remote] Remove CDP support from Remote Agent. r=webdriver-reviewers,jdescottes
Bug 1938638 - Remove deprecated "--enable-crash-reporter" argument from geckodriver r=webdriver-reviewers,Sasha
Bug 1985523 - [geckodriver] Try to relaunch Android testrunner when it failed first time. r=webdriver-reviewers,whimboo
Bug 1995453 - Remove unused XblLocatorParameters. r=webdriver-reviewers,whimboo
Bug 1969865 - Add tests for Global Privacy Control signal - r=jgraham,manuel
Bug 2000448 - [wdspec] Add wdspec tests for global_privacy_control - r=whimboo,geckodriver-reviewers,jgraham
Bug 2008345 - [geckodriver] Allow "null" for "implicit" and "pageLoad" timeouts. r=geckodriver-reviewers,jdescottes,jgraham
Bug 1943038 - [geckodriver] Use drop implementation to clean-up browser state. r=geckodriver-reviewers,jgraham
Bug 1943038 - [geckodriver] Only print MINIDUMP_SAVE_PATH info line if minidump files are present. r=geckodriver-reviewers,Sasha
Bug 2011832 - [geckodriver] Use mutex to run minidump tests sequentially. r=geckodriver-reviewers,Sasha,jgraham
Bug 1955044 - Update Geckodriver to Rust 2024, r=whimboo,geckodriver-reviewers
Bug 1955044 - Mark usage of env::set_var and env::use_var as unsafe r=whimboo,geckodriver-reviewers
Bug 1955044 - Fix new clippy warnings r=whimboo,geckodriver-reviewers
Bug 1925272 - [geckodriver] Stop creating addon files when installing an addon from base64 string. r=geckodriver-reviewers,whimboo
Bug 2021832 - Remove special cases when converting types to marionette r=geckodriver-reviewers,whimboo
Bug 1957746 - [geckodriver] Properly implement commands from the external WebAuthn specification. r=geckodriver-reviewers,jdescottes,jgraham
Bug 1839953 - [geckodriver] Detect when Firefox on Android exits during startup. r=geckodriver-reviewers,jgraham
Bug 2024589 - adjust the code: searchfox.org/mozilla-central is now redirecting to searchfox.org/firefox-main/ r=asuth,perftest-reviewers,necko-reviewers,jgraham,webcompat-reviewers,mozperftest-reviewers,geckoview-reviewers,extension-reviewers,credential-management-reviewers,devtools-reviewers,taskgraph-reviewers,releng-reviewers,desktop-theme-reviewers,win-reviewers,translations-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,core-sessionstore-reviewers,browser-installer-reviewers,profiles-reviewers,dom-worker-reviewers,geckodriver-reviewers,ai-platform-reviewers,Sasha,niklas,manuel,janerik,bhearsum,valentin,twisniewski,nchevobbe,emcminn,webrtc-reviewers,mjf,handyman,mconley,mossop,ahal,sparky,nrishel,robwu,ohall,dimi,hjones
Bug 1430064 - [geckodriver] Wait for graceful shutdown of Firefox on Android. r=geckodriver-reviewers,jgraham
Bug 2033393 - Adapt consumers to http 1.x, hyper 1.x, and windows-sys HANDLE type changes. r=necko-reviewers,geckodriver-reviewers,gsvelto,smaug,jgraham,gw,kershaw
Bug 2037801 - [geckodriver] Error and cleanup on invalid files in the profile. r=geckodriver-reviewers,jgraham

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1938333 - Update Rust crate dependencies for geckodriver 0.37.0.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1938333 - [geckodriver] Update changelog and bump version to 0.37.0.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1938333 - [geckodriver] Update changeset for the 0.37.0 release.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d2ff368b8faa
https://hg.mozilla.org/integration/autoland/rev/258e30f97d13
Update Rust crate dependencies for geckodriver 0.37.0. r=geckodriver-reviewers,Sasha,jgraham
https://github.com/mozilla-firefox/firefox/commit/0c18337207ef
https://hg.mozilla.org/integration/autoland/rev/24ca7f521328
[geckodriver] Update changelog and bump version to 0.37.0. r=geckodriver-reviewers,jgraham

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Marking as leave-open to first release it on GitHub before the bug gets closed.

Comment 12

[Goloman Adrian[:agoloman]]

https://hg.mozilla.org/mozilla-central/rev/258e30f97d13
https://hg.mozilla.org/mozilla-central/rev/24ca7f521328

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d4f7c54f23de
https://hg.mozilla.org/integration/autoland/rev/6b6f4d93e3e8
[geckodriver] Update changeset for the 0.37.0 release. r=geckodriver-reviewers,jgraham DONTBUILD

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The following crate dependencies have been released:

• https://crates.io/crates/mozdevice/0.5.5
• https://crates.io/crates/mozprofile/0.9.5
• https://crates.io/crates/mozversion/0.5.4
• https://crates.io/crates/mozrunner/0.15.5
• https://crates.io/crates/webdriver/0.54.0
• https://crates.io/crates/marionette/0.8.0

Comment 15

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/6b6f4d93e3e8

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Release v0.37.0 published:

• https://github.com/mozilla/geckodriver/releases/tag/v0.37.0
• https://crates.io/crates/geckodriver/0.37.0

I need to backport a changelog update and as well the releasing documentation by removing all the Mercurial commands. As such I'll leave this bug open for now.

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1938333 - [geckodriver] Update CHANGES.md for discontinued Linux builds and releasing documentation.

Comment 18

[Henrik Skupin [:whimboo][⌚️UTC+1]]

With landing the latest patch we can move forward and close the bug once it is merged to mozilla-central.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/68a7eea98e67
https://hg.mozilla.org/integration/autoland/rev/0e5a4195ab05
[geckodriver] Update CHANGES.md for discontinued Linux builds and releasing documentation. r=geckodriver-reviewers,jgraham DONTBUILD

Comment 20

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0e5a4195ab05