1957876 - Some uses of the legacy histogram APIs need to be removed before these APIs are removed in mozilla-central

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Florian Quèze [:florian]]

There is active work (eg bug 1956726) to remove the remaining legacy histogram consumers in mozilla-central. Once that work completes, the histogram.add API will be removed.

It looks like in addition to what we discussed in bug 1957605, there are 2 additional places where mail/ uses the histogram API:

• mail/modules/ExtensionsUI.sys.mjs for a SECURITY_UI histogram
• mail/modules/GlobalPopupNotifications.sys.mjs for various POPUP_NOTIFICATION_* histograms.

Comment 1

[Magnus Melin [:mkmelin] (away until Aug 10)]

For GlobalPopupNotifications.sys.mjs, that should ideally be re-synced with toolkit/modules/PopupNotifications.sys.mjs which would take care of it automatically. Or un-forked if we can (but probably can't). See bug 1872407.

mail/modules/ExtensionsUI.sys.mjs may have similar need to be synced up with browser/modules/ExtensionsUI.sys.mjs

Comment 2

[Florian Quèze [:florian]]

(In reply to Magnus Melin [:mkmelin] from comment #1)

mail/modules/ExtensionsUI.sys.mjs may have similar need to be synced up with browser/modules/ExtensionsUI.sys.mjs

In mozilla-central the SECURITY_UI histogram (not migrated to glean yet) is used from:

• browser/base/content/browser-addons.js
• dom/html/HTMLFormElement.cpp

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1957876 - Remove uses of legacy histogram APIs. r=mkmelin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b004b0134f2c
Remove uses of legacy histogram APIs. r=mkmelin