1964389 - Bottom toolbar is not hidden when autocomplete bars are expanded

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, defect, P3)

Description

[Petru-Mugurel Lingurar [:petru]]

Steps to reproduce(to test the logins autocomplete behavior)

1. Ensure the toolbar is positioned at bottom
2. Ensure you have passwords saved for the visited website
3. Visit a website with login form fields and tap these to see Fenix's autocomplete bar
4. Tap to expand the logins autocomplete bar

Expected behavior

The bottom toolbar (navbar also if enabled) is hidden when the autocomplete bar is shown

Actual behavior

The autocomplete bar is shown on top of the bottom toolbar, not hiding it.

Any additional information?

Tested only with the logins autocomplete bar, it's probable the issue affect the addresses and credit cards bars also.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Wanted-HidingToolbarWhenExpandingAutofill.mp4

Wanted UX

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: Issue - NotHidingToolbarWhenExpandingAutofill.mp4

Current (buggy) UX

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:boek, since you are the author of the regressor, bug 1951840, could you take a look?

For more information, please visit BugBot documentation.

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Think Segun covers for Boek for the time being, moving the NI.
@Segun Seems like something small that I think you have the context for. If you don't have capacity we can also take this.

Comment 5

[Segun Famisa [:segun]]

Thanks :petru,

We will have a look at it.

Comment 6

[Segun Famisa [:segun]]

We will ask to the UX folks, because I wonder if we actually should be hiding the toolbar.

Has it always been hidden? 🤔

Comment 7

[Petru-Mugurel Lingurar [:petru]]

(In reply to Segun Famisa [:segun] from comment #6)

We will ask to the UX folks, because I wonder if we actually should be hiding the toolbar.

Has it always been hidden? 🤔

Hiding the toolbar was implemented in bug 1909746 (which I linked to this ticket) and bug 1910409.
In bug 1909746 there is a recording from QA when verifying the implementation which shows the toolbar hiding UX.
I marked bug 1951840 as the regressor based on bisecting the code for when the behavior changed.

Comment 8

[Segun Famisa [:segun]]

Attachment: Bug 1964389 - Set autofill select bar behavior when expanded or collapsed

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd9ffa4ad087
Set autofill select bar behavior when expanded or collapsed r=android-reviewers,petru

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/cd9ffa4ad087

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:segun, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox140 to wontfix.

For more information, please visit BugBot documentation.