1966117 - [SearchConfig V2] Search engines are not loaded when starting up in airplane mode

Status: RESOLVED FIXED

(Firefox for Android :: Search, defect)

Description

[Mark Banner (:standard8)]

Steps to reproduce

1. On Firefox for Android Nightly - Secret Settings - enable the "Remote Search Configuration" toggle, and restart the app.
2. Check the available engines in the search button in the address bar.
3. Close the application fully, so that it quits.
4. Put the device into airplane mode.
5. Start Firefox for Android Nightly.
6. Check the search button in the address bar.

Expected behavior

• The engines available in step 2 are available in step 6.

Actual behavior

• No search engines are listed, only the Tabs/History/Search Settings options.

Device information

• Firefox version: Nightly 140.0a1

Any additional information?

I think that the application is not using the remote settings get_attachment API, and therefore the icons are not being loaded from the dumps / local cache.

Comment 1

[[:skhan]]

Attachment: Bug 1966117 - Fix search icons fetched from client

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8397c12d122a
Fix search icons fetched from client r=android-reviewers,harrisono

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c45d9f14ba3
Revert "Bug 1966117 - Fix search icons fetched from client r=android-reviewers,harrisono" for causing fenix ui-test failures

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing ui-test failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/3c45d9f14ba37a16a74bff39b342670e70569b44

Push with failures

Failure log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f94e672d208
Fix search icons fetched from client r=android-reviewers,harrisono

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/8f94e672d208