1966541 - Add promo card in the vertical tab strip to notify users they can pin tabs

Status: RESOLVED FIXED

(Firefox :: Sidebar, enhancement, P2)

Description

[Ania]

Spec

Acceptance criteria

1. The promo card is only displayed in the expanded sidebar state to vertical tab users who do not have any pinned tabs.
2. The card can be dismissed manually by clicking the X button. It is automatically dismissed by adding a pin via a context menu or by dragging the tab over the card and pinning.
3. While promo card is displayed, it prevents the interaction cue from showing.

Comment 1

[klower]

Just noting that the copy for the promo card is final. It is:

Drag important tabs here to keep them within reach

(Lack of period is intentional)

Spec update in progress

Comment 2

[Ania]

Attachment: Final copy image

Comment 3

[Yulia Popova]

Just FYI the image uploaded is not the final one. See spec for final copy and image - https://www.figma.com/design/URUNfOzQNRFiQnz67coSd0/Sidebar-Enhancements-Specs?node-id=8092-6174&t=1k1k7CrLRRw2NvgT-4

Comment 5

[Jonathan Sudiaman [:jsudiaman]]

Attachment: Bug 1966541 - Add promo card in the vertical tab strip to notify users they can pin tabs r?#sidebar-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2599863bb0cc
https://hg.mozilla.org/integration/autoland/rev/1946f1af163c
Add promo card in the vertical tab strip to notify users they can pin tabs r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,tabbrowser-reviewers,kcochrane,nsharpley,Itiel

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/eb6d6c551b5c
https://hg.mozilla.org/integration/autoland/rev/37b7b23178e3
Revert "Bug 1966541 - Add promo card in the vertical tab strip to notify users they can pin tabs r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,tabbrowser-reviewers,kcochrane,nsharpley,Itiel" for causing mochitets failures on test_tabbrowser.xhtml

Comment 8

[Cristina Horotan [:chorotan]]

Backed out for causing bc failures on browser_urlbar_selection.js

Backout link

Push with failures

Failure log

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ba8f58ab5812
https://hg.mozilla.org/integration/autoland/rev/5866f4764017
Add promo card in the vertical tab strip to notify users they can pin tabs r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,tabbrowser-reviewers,kcochrane,nsharpley,Itiel,sfoster

Comment 10

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/5866f4764017